Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2835403004: Revert "Use MojoCompositorFrameSink in RendererCompositorFrameSink"

Created:
3 years, 8 months ago by Saman Sami
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, qsr+mojo_chromium.org, jam, abarth-chromium, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, xjz+watch_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, shuchen+watch_chromium.org, Aaron Boodman, mac-reviews_chromium.org, darin (slow to review), James Su
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Use MojoCompositorFrameSink in RendererCompositorFrameSink" CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : fixed #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -527 lines) Patch
M content/browser/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 2 chunks +1 line, -5 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc View 3 chunks +0 lines, -17 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest_unittest.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M content/browser/renderer_host/browser_compositor_view_mac.h View 4 chunks +7 lines, -4 lines 0 comments Download
M content/browser/renderer_host/browser_compositor_view_mac.mm View 2 chunks +9 lines, -5 lines 0 comments Download
M content/browser/renderer_host/delegated_frame_host.h View 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/renderer_host/delegated_frame_host.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M content/browser/renderer_host/delegated_frame_host_client_aura.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/delegated_frame_host_client_aura.cc View 1 chunk +8 lines, -0 lines 0 comments Download
D content/browser/renderer_host/frame_sink_provider_impl.h View 1 chunk +0 lines, -39 lines 0 comments Download
D content/browser/renderer_host/frame_sink_provider_impl.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 3 chunks +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 4 chunks +0 lines, -15 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 7 chunks +18 lines, -22 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 8 chunks +37 lines, -36 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 4 chunks +50 lines, -18 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 2 chunks +1 line, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 2 chunks +3 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 2 chunks +1 line, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 2 chunks +3 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 11 chunks +28 lines, -39 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 2 chunks +9 lines, -4 lines 0 comments Download
M content/common/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D content/common/frame_sink_provider.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
M content/common/swapped_out_messages.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/view_messages.h View 2 chunks +13 lines, -0 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/compositor_forwarding_message_filter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/renderer_compositor_frame_sink.h View 7 chunks +11 lines, -18 lines 0 comments Download
M content/renderer/gpu/renderer_compositor_frame_sink.cc View 11 chunks +41 lines, -47 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 3 chunks +0 lines, -7 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 5 chunks +11 lines, -12 lines 0 comments Download
M content/test/BUILD.gn View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
D content/test/fake_renderer_compositor_frame_sink.h View 1 chunk +0 lines, -51 lines 0 comments Download
D content/test/fake_renderer_compositor_frame_sink.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/test/test_render_view_host.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (9 generated)
Saman Sami
Description was changed from ========== Revert "Use MojoCompositorFrameSink in RendererCompositorFrameSink" ========== to ========== Revert "Use ...
3 years, 8 months ago (2017-04-26 14:09:05 UTC) #1
Saman Sami
The CQ bit was checked by samans@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-26 14:10:13 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835403004/20001
3 years, 8 months ago (2017-04-26 14:10:35 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-26 14:14:10 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/280088) linux_chromium_compile_dbg_ng on ...
3 years, 8 months ago (2017-04-26 14:14:11 UTC) #5
Saman Sami
The CQ bit was checked by samans@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-26 14:15:01 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835403004/40001
3 years, 8 months ago (2017-04-26 14:15:25 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-26 16:05:39 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 16:05:40 UTC) #9 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698