Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3533)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 2835403004: Revert "Use MojoCompositorFrameSink in RendererCompositorFrameSink"
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_thread_impl.h ('k') | content/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index 096997042ba104fc3b2d6947e06f55c138da8e5f..94cd3ab3ed586df8ee46ea74df2c4d2899632443 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -251,10 +251,8 @@ const double kThrottledResourceRequestFlushPeriodS = 1. / 60.;
// allocation that exceeds this limit.
const size_t kImageCacheSingleAllocationByteLimit = 64 * 1024 * 1024;
-#if defined(OS_ANDROID)
// Unique identifier for each output surface created.
uint32_t g_next_compositor_frame_sink_id = 1;
-#endif
// An implementation of mojom::RenderMessageFilter which can be mocked out
// for tests which may indirectly send messages over this interface.
@@ -894,9 +892,6 @@ void RenderThreadImpl::Init(
// redirection experiment concludes https://crbug.com/622400.
if (!command_line.HasSwitch(switches::kSingleProcess))
base::SequencedWorkerPool::EnableForProcess();
-
- GetConnector()->BindInterface(mojom::kBrowserServiceName,
- mojo::MakeRequest(&frame_sink_provider_));
}
RenderThreadImpl::~RenderThreadImpl() {
@@ -1864,13 +1859,16 @@ void RenderThreadImpl::RequestNewCompositorFrameSink(
}
#endif
+ uint32_t compositor_frame_sink_id = g_next_compositor_frame_sink_id++;
+
if (command_line.HasSwitch(switches::kEnableVulkan)) {
scoped_refptr<cc::VulkanContextProvider> vulkan_context_provider =
cc::VulkanInProcessContextProvider::Create();
if (vulkan_context_provider) {
DCHECK(!layout_test_mode());
callback.Run(base::MakeUnique<RendererCompositorFrameSink>(
- routing_id, std::move(synthetic_begin_frame_source),
+ routing_id, compositor_frame_sink_id,
+ std::move(synthetic_begin_frame_source),
std::move(vulkan_context_provider),
std::move(frame_swap_message_queue)));
return;
@@ -1896,8 +1894,9 @@ void RenderThreadImpl::RequestNewCompositorFrameSink(
if (use_software) {
DCHECK(!layout_test_mode());
callback.Run(base::MakeUnique<RendererCompositorFrameSink>(
- routing_id, std::move(synthetic_begin_frame_source), nullptr, nullptr,
- nullptr, shared_bitmap_manager(), std::move(frame_swap_message_queue)));
+ routing_id, compositor_frame_sink_id,
+ std::move(synthetic_begin_frame_source), nullptr, nullptr, nullptr,
+ shared_bitmap_manager(), std::move(frame_swap_message_queue)));
return;
}
@@ -1958,16 +1957,16 @@ void RenderThreadImpl::RequestNewCompositorFrameSink(
callback.Run(base::MakeUnique<SynchronousCompositorFrameSink>(
std::move(context_provider), std::move(worker_context_provider),
GetGpuMemoryBufferManager(), shared_bitmap_manager(), routing_id,
- g_next_compositor_frame_sink_id++, std::move(begin_frame_source),
+ compositor_frame_sink_id, std::move(begin_frame_source),
sync_compositor_message_filter_.get(),
std::move(frame_swap_message_queue)));
return;
}
#endif
callback.Run(base::WrapUnique(new RendererCompositorFrameSink(
- routing_id, std::move(synthetic_begin_frame_source),
- std::move(context_provider), std::move(worker_context_provider),
- GetGpuMemoryBufferManager(), nullptr,
+ routing_id, compositor_frame_sink_id,
+ std::move(synthetic_begin_frame_source), std::move(context_provider),
+ std::move(worker_context_provider), GetGpuMemoryBufferManager(), nullptr,
std::move(frame_swap_message_queue))));
}
« no previous file with comments | « content/renderer/render_thread_impl.h ('k') | content/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698