Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2835313002:
Use TaskScheduler instead of blocking pool in supervised_user_blacklist.cc. (Closed)
|
Created:
3 years, 8 months ago by fdoray Modified:
3 years, 7 months ago Reviewers:
Bernhard Bauer CC:
chromium-reviews, pam+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse TaskScheduler instead of blocking pool in supervised_user_blacklist.cc.
The blocking pool is being deprecated in favor of TaskScheduler.
BUG=667892
R=bauerb@chromium.org
Review-Url: https://codereview.chromium.org/2835313002
Cr-Commit-Position: refs/heads/master@{#467661}
Committed: https://chromium.googlesource.com/chromium/src/+/95bfc8dbca7ee83b4d8f3f352f7b6862ca31c559
Patch Set 1 #
Total comments: 1
Patch Set 2 : PostTaskWithTraitsAndReplyWithResult #Messages
Total messages: 17 (11 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
PTAL! This CL was generated automatically. Please make sure that the appropriate TaskTraits are used to post tasks. https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h If everything looks good, please lgtm and CQ this CL. Otherwise, tell us what's wrong. Thanks! - FAQ - What if bots are red? Ignore this CL. A human will look at errors shortly. What if the task priority is not set explicitly (no .WithTaskPriority())? When there is no explicit priority, the priority is inherited from the calling context (e.g. a task posted from a BACKGROUND task without an explicit priority will have a BACKGROUND priority). What if the shutdown behavior is not set explicitly (no .WithShutdownBehavior())? If shutdown behavior is important for a task, it should be set explicitly. It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or SKIP_ON_SHUTDOWN.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ping On 2017/04/24 19:42:01, fdoray wrote: > PTAL! > > This CL was generated automatically. > > Please make sure that the appropriate TaskTraits are used to post tasks. > https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h > If everything looks good, please lgtm and CQ this CL. Otherwise, tell > us what's wrong. > > Thanks! > > - FAQ - > > What if bots are red? Ignore this CL. A human will look at errors shortly. > > What if the task priority is not set explicitly (no .WithTaskPriority())? > When there is no explicit priority, the priority is inherited from the > calling context (e.g. a task posted from a BACKGROUND task without an > explicit priority will have a BACKGROUND priority). > > What if the shutdown behavior is not set explicitly > (no .WithShutdownBehavior())? > If shutdown behavior is important for a task, it should be set explicitly. > It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN > or SKIP_ON_SHUTDOWN.
lgtm LGTM https://codereview.chromium.org/2835313002/diff/1/chrome/browser/supervised_u... File chrome/browser/supervised_user/experimental/supervised_user_blacklist.cc (right): https://codereview.chromium.org/2835313002/diff/1/chrome/browser/supervised_u... chrome/browser/supervised_user/experimental/supervised_user_blacklist.cc:77: base::PostTaskAndReplyWithResult( Sorry, I thought I had replied here as well. Can you use PostTaskWithTraitsAndReplyWithResult() here? And maybe replace base::Bind() with base::BindOnce()? Thanks!
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by fdoray@chromium.org
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org Link to the patchset: https://codereview.chromium.org/2835313002/#ps20001 (title: "PostTaskWithTraitsAndReplyWithResult")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493298211959410,
"parent_rev": "92b8aa533768e2e92c14873f398c0806088733ad", "commit_rev":
"95bfc8dbca7ee83b4d8f3f352f7b6862ca31c559"}
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of blocking pool in supervised_user_blacklist.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=bauerb@chromium.org ========== to ========== Use TaskScheduler instead of blocking pool in supervised_user_blacklist.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=bauerb@chromium.org Review-Url: https://codereview.chromium.org/2835313002 Cr-Commit-Position: refs/heads/master@{#467661} Committed: https://chromium.googlesource.com/chromium/src/+/95bfc8dbca7ee83b4d8f3f352f7b... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/95bfc8dbca7ee83b4d8f3f352f7b... |
