Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: chrome/browser/supervised_user/experimental/supervised_user_blacklist.cc

Issue 2835313002: Use TaskScheduler instead of blocking pool in supervised_user_blacklist.cc. (Closed)
Patch Set: PostTaskWithTraitsAndReplyWithResult Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/supervised_user/experimental/supervised_user_blacklist.cc
diff --git a/chrome/browser/supervised_user/experimental/supervised_user_blacklist.cc b/chrome/browser/supervised_user/experimental/supervised_user_blacklist.cc
index a5163cc796f638a9196c3253c2936a471f4f8d84..b8cf356845c0dd1c3c002be1a7b684877588134b 100644
--- a/chrome/browser/supervised_user/experimental/supervised_user_blacklist.cc
+++ b/chrome/browser/supervised_user/experimental/supervised_user_blacklist.cc
@@ -10,18 +10,13 @@
#include "base/files/file_path.h"
#include "base/files/memory_mapped_file.h"
-#include "base/threading/sequenced_worker_pool.h"
-#include "content/public/browser/browser_thread.h"
+#include "base/task_scheduler/post_task.h"
#include "url/gurl.h"
-using content::BrowserThread;
-
namespace {
std::unique_ptr<std::vector<SupervisedUserBlacklist::Hash>>
ReadFromBinaryFileOnFileThread(const base::FilePath& path) {
- DCHECK(BrowserThread::GetBlockingPool()->RunsTasksOnCurrentThread());
-
std::unique_ptr<std::vector<SupervisedUserBlacklist::Hash>> host_hashes(
new std::vector<SupervisedUserBlacklist::Hash>);
@@ -75,14 +70,16 @@ size_t SupervisedUserBlacklist::GetEntryCount() const {
void SupervisedUserBlacklist::ReadFromFile(const base::FilePath& path,
const base::Closure& done_callback) {
- base::PostTaskAndReplyWithResult(
- BrowserThread::GetBlockingPool()->GetTaskRunnerWithShutdownBehavior(
- base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN).get(),
+ base::PostTaskWithTraitsAndReplyWithResult(
FROM_HERE,
- base::Bind(&ReadFromBinaryFileOnFileThread, path),
- base::Bind(&SupervisedUserBlacklist::OnReadFromFileCompleted,
- weak_ptr_factory_.GetWeakPtr(),
- done_callback));
+ base::TaskTraits()
+ .MayBlock()
+ .WithPriority(base::TaskPriority::BACKGROUND)
+ .WithShutdownBehavior(
+ base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN),
+ base::BindOnce(&ReadFromBinaryFileOnFileThread, path),
+ base::BindOnce(&SupervisedUserBlacklist::OnReadFromFileCompleted,
+ weak_ptr_factory_.GetWeakPtr(), done_callback));
}
void SupervisedUserBlacklist::OnReadFromFileCompleted(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698