chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc - Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)

Patch Set: ready for review Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc ('k') | chrome/browser/extensions/app_background_page_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc

diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc

index 4dd5d71b1f92549015616212382bf572c0ae7e8b..f2ee8aabe3ae196a65d87750adc7b65078149294 100644

--- a/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc

+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc

@@ -8,6 +8,7 @@

#include "base/files/file_util.h"

#include "base/macros.h"

#include "base/strings/utf_string_conversions.h"

+#include "base/threading/thread_restrictions.h"

#include "build/build_config.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/extensions/api/webstore_private/webstore_private_api.h"

@@ -218,6 +219,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebstorePrivateApiTest, InstallAccepted) {

// Test having the default download directory missing.

IN_PROC_BROWSER_TEST_F(ExtensionWebstorePrivateApiTest, MissingDownloadDir) {

// Set a non-existent directory as the download path.

+ base::ThreadRestrictions::ScopedAllowIO allow_io;

base::ScopedTempDir temp_dir;

EXPECT_TRUE(temp_dir.CreateUniqueTempDir());

base::FilePath missing_directory = temp_dir.Take();