chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc - Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)

Patch Set: ready for review Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc

diff --git a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc

index 17266643b89c966a5ed604ae72b641341ca410c8..4c040ef09e0302b938566fceb2b4f307db460e42 100644

--- a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc

+++ b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc

@@ -12,6 +12,7 @@

#include "base/run_loop.h"

#include "base/strings/string_number_conversions.h"

#include "base/threading/platform_thread.h"

+#include "base/threading/thread_restrictions.h"

#include "base/time/time.h"

#include "build/build_config.h"

#include "chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.h"

@@ -65,6 +66,7 @@ class FileWaiter : public base::RefCountedThreadSafe<FileWaiter> {

: found_(false), path_(path) {}

bool Start() {

+ base::ThreadRestrictions::ScopedAllowIO allow_io;

if (base::PathExists(path_)) {

found_ = true;

return true;

@@ -233,6 +235,7 @@ IN_PROC_BROWSER_TEST_F(WebrtcEventLogApiTest, TestStartStopWebRtcEventLogging) {

ASSERT_TRUE(waiter->Start()) << "ERROR watching for "

<< full_file_name.value();

ASSERT_TRUE(waiter->WaitForFile());

+ base::ThreadRestrictions::ScopedAllowIO allow_io;

ASSERT_TRUE(base::PathExists(full_file_name));

EXPECT_TRUE(base::GetFileSize(full_file_name, &file_size));

EXPECT_GT(file_size, 0);

@@ -243,6 +246,7 @@ IN_PROC_BROWSER_TEST_F(WebrtcEventLogApiTest, TestStartStopWebRtcEventLogging) {

IN_PROC_BROWSER_TEST_F(WebrtcEventLogApiTest,

TestStartTimedWebRtcEventLogging) {

+ base::ThreadRestrictions::ScopedAllowIO allow_io;

ASSERT_TRUE(embedded_test_server()->Start());

content::WebContents* left_tab =