Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1629)

Unified Diff: chrome/browser/extensions/app_background_page_apitest.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)
Patch Set: ready for review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/app_background_page_apitest.cc
diff --git a/chrome/browser/extensions/app_background_page_apitest.cc b/chrome/browser/extensions/app_background_page_apitest.cc
index ad16e39dc46e063f3b4353aab84a8039eaf573ea..b6a70ee6bf8bc7070dcf2e985b2d9a166c3db554 100644
--- a/chrome/browser/extensions/app_background_page_apitest.cc
+++ b/chrome/browser/extensions/app_background_page_apitest.cc
@@ -7,6 +7,7 @@
#include "base/single_thread_task_runner.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
+#include "base/threading/thread_restrictions.h"
#include "base/threading/thread_task_runner_handle.h"
#include "build/build_config.h"
#include "chrome/browser/background/background_contents_service.h"
@@ -54,6 +55,7 @@ class AppBackgroundPageApiTest : public ExtensionApiTest {
bool CreateApp(const std::string& app_manifest,
base::FilePath* app_dir) {
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
if (!app_dir_.CreateUniqueTempDir()) {
LOG(ERROR) << "Unable to create a temporary directory.";
return false;
@@ -129,6 +131,7 @@ class AppBackgroundPageNaClTest : public AppBackgroundPageApiTest {
protected:
void LaunchTestingApp() {
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
base::FilePath app_dir;
PathService::Get(chrome::DIR_GEN_TEST_DATA, &app_dir);
app_dir = app_dir.AppendASCII(

Powered by Google App Engine
This is Rietveld 408576698