chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc - Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)

Patch Set: ready for review Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/streams_private/streams_private_apitest.cc ('k') | chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

index 7ca55aa75e89469fd63c4e55e32d74371925a164..9f82d5df9c53fb4d1bc750401348d51913d7de29 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

@@ -13,6 +13,7 @@

#include "base/strings/string_util.h"

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

+#include "base/threading/thread_restrictions.h"

#include "build/build_config.h"

#include "chrome/app/chrome_command_ids.h"

#include "chrome/browser/browser_process.h"

@@ -406,6 +407,7 @@ IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, DISABLED_ServerRedirect) {

}

IN_PROC_BROWSER_TEST_F(WebNavigationApiTest, Download) {

+ base::ThreadRestrictions::ScopedAllowIO allow_io;

base::ScopedTempDir download_directory;

ASSERT_TRUE(download_directory.CreateUniqueTempDir());

DownloadPrefs* download_prefs =