chrome/browser/apps/guest_view/web_view_browsertest.cc - Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)

Patch Set: ready for review Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm ('k') | chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/guest_view/web_view_browsertest.cc

diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc

index ac627007df6ef67f9f3f210b6b4157dc757bf23d..4915460b4f5471d86cc1558ac57a27a9277d2486 100644

--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc

+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc

@@ -19,6 +19,7 @@

#include "base/strings/string_number_conversions.h"

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

+#include "base/threading/thread_restrictions.h"

#include "base/threading/thread_task_runner_handle.h"

#include "build/build_config.h"

#include "chrome/app/chrome_command_ids.h"

@@ -2558,6 +2559,7 @@ IN_PROC_BROWSER_TEST_P(WebViewTest, DownloadPermission) {

"web_view/download");

ASSERT_TRUE(guest_web_contents);

+ base::ThreadRestrictions::ScopedAllowIO allow_io;

base::ScopedTempDir temporary_download_dir;

ASSERT_TRUE(temporary_download_dir.CreateUniqueTempDir());

DownloadPrefs::FromBrowserContext(guest_web_contents->GetBrowserContext())

@@ -2715,6 +2717,7 @@ IN_PROC_BROWSER_TEST_P(WebViewTest, DownloadCookieIsolation) {

content::WebContents* web_contents = GetFirstAppWindowWebContents();

ASSERT_TRUE(web_contents);

+ base::ThreadRestrictions::ScopedAllowIO allow_io;

base::ScopedTempDir temporary_download_dir;

ASSERT_TRUE(temporary_download_dir.CreateUniqueTempDir());

DownloadPrefs::FromBrowserContext(web_contents->GetBrowserContext())

@@ -2800,6 +2803,7 @@ IN_PROC_BROWSER_TEST_P(WebViewTest, PRE_DownloadCookieIsolation_CrossSession) {

content::WebContents* web_contents = GetFirstAppWindowWebContents();

ASSERT_TRUE(web_contents);

+ base::ThreadRestrictions::ScopedAllowIO allow_io;

base::ScopedTempDir temporary_download_dir;

ASSERT_TRUE(temporary_download_dir.CreateUniqueTempDir());

DownloadPrefs::FromBrowserContext(web_contents->GetBrowserContext())

@@ -2858,6 +2862,7 @@ IN_PROC_BROWSER_TEST_P(WebViewTest, DownloadCookieIsolation_CrossSession) {

DownloadHistoryWaiter history_waiter(browser_context);

history_waiter.WaitForHistoryLoad();

+ base::ThreadRestrictions::ScopedAllowIO allow_io;

base::ScopedTempDir temporary_download_dir;

ASSERT_TRUE(temporary_download_dir.Set(

DownloadPrefs::FromBrowserContext(browser_context)->DownloadPath()));