Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3254)

Unified Diff: chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)
Patch Set: ready for review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
diff --git a/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm b/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
index ea990bd9367ec7e31e32d3bde86d3b714c26a4fd..238e0e1d2c79d51172d675be8575bdb3a3e760b0 100644
--- a/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
+++ b/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
@@ -18,6 +18,7 @@
#include "base/strings/sys_string_conversions.h"
#include "base/test/scoped_feature_list.h"
#include "base/test/test_timeouts.h"
+#include "base/threading/thread_restrictions.h"
#include "build/build_config.h"
#include "chrome/browser/apps/app_browsertest_util.h"
#include "chrome/browser/apps/app_shim/app_shim_handler_mac.h"
@@ -261,6 +262,7 @@ const extensions::Extension* AppShimInteractiveTest::InstallAppWithShim(
// (always) in tests. If it wasn't the case, the following test would fail
// (but flakily since the creation happens on the FILE thread).
shim_path_ = GetAppShimPath(profile(), app);
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
EXPECT_FALSE(base::PathExists(shim_path_));
// To create a shim in a test, instead call UpdateAllShortcuts, which has been

Powered by Google App Engine
This is Rietveld 408576698