Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc

Issue 2835233002: Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks wi... (Closed)
Patch Set: ready for review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc
diff --git a/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc b/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc
index 0851507286e4c318ef23bcc4c6796917bd6b9e90..8524ba334c0890e82b55f80a3324b180e15bb6f6 100644
--- a/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc
+++ b/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc
@@ -19,6 +19,7 @@
#include "base/strings/utf_string_conversions.h"
#include "base/test/thread_test_helper.h"
#include "base/threading/sequenced_worker_pool.h"
+#include "base/threading/thread_restrictions.h"
#include "chrome/browser/browsing_data/browsing_data_helper_browsertest.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
@@ -54,6 +55,7 @@ const base::FilePath::CharType kTestFileExtension[] = FILE_PATH_LITERAL(
class BrowsingDataLocalStorageHelperTest : public InProcessBrowserTest {
protected:
void CreateLocalStorageFilesForTest() {
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
// Note: This helper depends on details of how the dom_storage library
// stores data in the host file system.
base::FilePath storage_path = GetLocalStoragePathForTestingProfile();
@@ -128,6 +130,7 @@ IN_PROC_BROWSER_TEST_F(BrowsingDataLocalStorageHelperTest, DeleteSingleFile) {
content::RunAllBlockingPoolTasksUntilIdle();
// Ensure the file has been deleted.
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
base::FileEnumerator file_enumerator(
GetLocalStoragePathForTestingProfile(),
false,

Powered by Google App Engine
This is Rietveld 408576698