Fix logdog_wrapper to not upload if logdog binary does not exist.

Fix logdog_wrapper to not upload if logdog binary does not exist.

Currently when logdog binary doesn not exist, we are still trying to
upload logcats. Without logdog binary setting up, trying to upload
logcats will result in NotBootstrappedError. This error will then output
a stack which is confusing to engineers.

BUG=675666
Review-Url: https://codereview.chromium.org/2835203004
Cr-Commit-Position: refs/heads/master@{#467505}
Committed: https://chromium.googlesource.com/chromium/src/+/9efa729c382c00ae0746a4abf98e4358d9f12ff4

[BigBossZhiling, 2017-04-24 21:08:47]

Description was changed from

==========
Fix logdog_wrapper to not upload if logdog binary does not exist.

Currently when logdog binary doesn not exist, we are still trying to
upload logcats. Without logdog binary setting up, trying to upload
logcats will result in NotBootstrappedError. This error will then output
a stack which is confusing to engineers.

BUG=675666
==========

to

==========
Fix logdog_wrapper to not upload if logdog binary does not exist.

Currently when logdog binary doesn not exist, we are still trying to
upload logcats. Without logdog binary setting up, trying to upload
logcats will result in NotBootstrappedError. This error will then output
a stack which is confusing to engineers.

BUG=675666
==========

[BigBossZhiling, 2017-04-24 21:08:47]

hzl@google.com changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2017-04-24 22:02:51]

https://codereview.chromium.org/2835203004/diff/1/build/android/test_wrapper/...
File build/android/test_wrapper/logdog_wrapper.py (right):

https://codereview.chromium.org/2835203004/diff/1/build/android/test_wrapper/...
build/android/test_wrapper/logdog_wrapper.py:69: test_cmd += extra_cmd_args
Can we move this below the if/else block and just do it once?

[jbudorick, 2017-04-24 22:26:29]

lgtm w/ nit

https://codereview.chromium.org/2835203004/diff/20001/build/android/pylib/uti...
File build/android/pylib/utils/decorators.py (right):

https://codereview.chromium.org/2835203004/diff/20001/build/android/pylib/uti...
build/android/pylib/utils/decorators.py:35: logging.exception('The above
exception is suppressed on purpose. '
Could we just change the default exception_message to 'Exception suppressed.' ?

[mikecase (-- gone --), 2017-04-24 22:33:40]

mikecase@chromium.org changed reviewers:
+ mikecase@chromium.org

[mikecase (-- gone --), 2017-04-24 22:33:41]

https://codereview.chromium.org/2835203004/diff/20001/build/android/pylib/uti...
File build/android/pylib/utils/decorators.py (right):

https://codereview.chromium.org/2835203004/diff/20001/build/android/pylib/uti...
build/android/pylib/utils/decorators.py:35: logging.exception('The above
exception is suppressed on purpose. '
On 2017/04/24 at 22:26:29, jbudorick wrote:
> Could we just change the default exception_message to 'Exception suppressed.'
?

Im not the biggest fan of this. If people are being specifically confused by the
logdog exception spam, you could just set the exception_message arg as like
'Ignore this exception, crbug/123456' in logdog_helper or w/e it is being
raised.

[BigBossZhiling, 2017-04-25 18:13:47]

https://codereview.chromium.org/2835203004/diff/20001/build/android/pylib/uti...
File build/android/pylib/utils/decorators.py (right):

https://codereview.chromium.org/2835203004/diff/20001/build/android/pylib/uti...
build/android/pylib/utils/decorators.py:35: logging.exception('The above
exception is suppressed on purpose. '
On 2017/04/24 22:33:40, mikecase wrote:
> On 2017/04/24 at 22:26:29, jbudorick wrote:
> > Could we just change the default exception_message to 'Exception
suppressed.'
> ?
> 
> Im not the biggest fan of this. If people are being specifically confused by
the
> logdog exception spam, you could just set the exception_message arg as like
> 'Ignore this exception, crbug/123456' in logdog_helper or w/e it is being
> raised.

Done.

[jbudorick, 2017-04-25 18:14:48]

https://codereview.chromium.org/2835203004/diff/40001/build/android/pylib/uti...
File build/android/pylib/utils/decorators.py (right):

https://codereview.chromium.org/2835203004/diff/40001/build/android/pylib/uti...
build/android/pylib/utils/decorators.py:34: logging.exception('Ignore the
following exception.')
This will log the exception twice, which we definitely don't want to do.

[BigBossZhiling, 2017-04-26 20:55:47]

https://codereview.chromium.org/2835203004/diff/40001/build/android/pylib/uti...
File build/android/pylib/utils/decorators.py (right):

https://codereview.chromium.org/2835203004/diff/40001/build/android/pylib/uti...
build/android/pylib/utils/decorators.py:34: logging.exception('Ignore the
following exception.')
On 2017/04/25 18:14:48, jbudorick wrote:
> This will log the exception twice, which we definitely don't want to do.

Done.

[mikecase (-- gone --), 2017-04-26 20:59:49]

lgtm

https://codereview.chromium.org/2835203004/diff/60001/build/android/pylib/uti...
File build/android/pylib/utils/logdog_helper.py (right):

https://codereview.chromium.org/2835203004/diff/60001/build/android/pylib/uti...
build/android/pylib/utils/logdog_helper.py:20: exception_message='Ignore this
exception.')
nit: I would link a crbug here with some context.

[BigBossZhiling, 2017-04-26 21:24:07]

https://codereview.chromium.org/2835203004/diff/60001/build/android/pylib/uti...
File build/android/pylib/utils/logdog_helper.py (right):

https://codereview.chromium.org/2835203004/diff/60001/build/android/pylib/uti...
build/android/pylib/utils/logdog_helper.py:20: exception_message='Ignore this
exception.')
On 2017/04/26 20:59:49, mikecase wrote:
> nit: I would link a crbug here with some context.

Done.

[BigBossZhiling, 2017-04-26 21:25:10]

The CQ bit was checked by hzl@google.com

[BigBossZhiling, 2017-04-26 21:25:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org, mikecase@chromium.org
Link to the patchset: https://codereview.chromium.org/2835203004/#ps100001
(title: "fixes")

[commit-bot: I haz the power, 2017-04-26 21:25:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 23:23:44]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493241910999700,
"parent_rev": "d476ca3a02a6c06d45ef3d83573fa094ca4f52d7", "commit_rev":
"9efa729c382c00ae0746a4abf98e4358d9f12ff4"}

[commit-bot: I haz the power, 2017-04-26 23:23:50]

Description was changed from

==========
Fix logdog_wrapper to not upload if logdog binary does not exist.

Currently when logdog binary doesn not exist, we are still trying to
upload logcats. Without logdog binary setting up, trying to upload
logcats will result in NotBootstrappedError. This error will then output
a stack which is confusing to engineers.

BUG=675666
==========

to

==========
Fix logdog_wrapper to not upload if logdog binary does not exist.

Currently when logdog binary doesn not exist, we are still trying to
upload logcats. Without logdog binary setting up, trying to upload
logcats will result in NotBootstrappedError. This error will then output
a stack which is confusing to engineers.

BUG=675666

Review-Url: https://codereview.chromium.org/2835203004
Cr-Commit-Position: refs/heads/master@{#467505}
Committed:
https://chromium.googlesource.com/chromium/src/+/9efa729c382c00ae0746a4abf98e...
==========

[commit-bot: I haz the power, 2017-04-26 23:23:51]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/9efa729c382c00ae0746a4abf98e...