Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4764)

Unified Diff: build/android/pylib/utils/logdog_helper.py

Issue 2835203004: Fix logdog_wrapper to not upload if logdog binary does not exist. (Closed)
Patch Set: fixes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/test_wrapper/logdog_wrapper.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/utils/logdog_helper.py
diff --git a/build/android/pylib/utils/logdog_helper.py b/build/android/pylib/utils/logdog_helper.py
index f5e4137a68c8b5737c793f183c2198a0db423fb0..c77ec2ae908c89d85ef94461f228c22bb1725d17 100644
--- a/build/android/pylib/utils/logdog_helper.py
+++ b/build/android/pylib/utils/logdog_helper.py
@@ -16,7 +16,9 @@ sys.path.insert(0, os.path.abspath(os.path.join(
from libs.logdog import bootstrap # pylint: disable=import-error
-@decorators.NoRaiseException(default_return_value='')
+@decorators.NoRaiseException(default_return_value='',
+ exception_message=('Ignore this exception. '
+ 'crbug.com/675666'))
def text(name, data):
"""Uploads text to logdog.
@@ -33,7 +35,9 @@ def text(name, data):
return stream.get_viewer_url()
-@decorators.NoRaiseException(default_return_value=None)
+@decorators.NoRaiseException(default_return_value=None,
+ exception_message=('Ignore this exception. '
+ 'crbug.com/675666'))
def open_text(name):
"""Returns a file like object which you can write to.
@@ -47,7 +51,9 @@ def open_text(name):
return get_logdog_client().open_text(name)
-@decorators.NoRaiseException(default_return_value='')
+@decorators.NoRaiseException(default_return_value='',
+ exception_message=('Ignore this exception. '
+ 'crbug.com/675666'))
def binary(name, binary_path):
"""Uploads binary to logdog.
@@ -65,7 +71,9 @@ def binary(name, binary_path):
return stream.get_viewer_url()
-@decorators.NoRaiseException(default_return_value='')
+@decorators.NoRaiseException(default_return_value='',
+ exception_message=('Ignore this exception. '
+ 'crbug.com/675666'))
def get_viewer_url(name):
"""Get Logdog viewer URL.
« no previous file with comments | « no previous file | build/android/test_wrapper/logdog_wrapper.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698