Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2835103002: Move blobalizer implementation to ShapeResultBloberizer (Closed)

Created:
3 years, 8 months ago by eae
Modified:
3 years, 8 months ago
Reviewers:
drott
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, fmalita+watch_chromium.org, Rik, Justin Novosad, blink-reviews, kinuko+watch, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move blobalizer implementation to ShapeResultBloberizer Move blobalizer logic out of CachingWordShaper and ShapeResultBuffer and into ShapeResultBloberizer, thereby containing all blobalizer logic in a single file and removing dependencies on it from the results and shaper. This will also help in reusing much of the text blob logic for LayoutNG. R=drott@chromium.org TEST=Source/platform/fonts/shaping/ShapeResultBloberizerTest.cpp Review-Url: https://codereview.chromium.org/2835103002 Cr-Commit-Position: refs/heads/master@{#466891} Committed: https://chromium.googlesource.com/chromium/src/+/fc5c8f986bf31478c6dc3c082f3ba8b216f24e21

Patch Set 1 #

Patch Set 2 : Fix canvas tests #

Messages

Total messages: 15 (10 generated)
eae
3 years, 8 months ago (2017-04-24 09:06:05 UTC) #1
eae
FYI, this is a pure refactoring - no functionality changes. Next step is adding support ...
3 years, 8 months ago (2017-04-24 09:17:03 UTC) #4
drott
On 2017/04/24 at 09:17:03, eae wrote: > Next step is adding support for blobarizing ShapeResults ...
3 years, 8 months ago (2017-04-25 01:26:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835103002/20001
3 years, 8 months ago (2017-04-25 02:21:41 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 05:30:32 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fc5c8f986bf31478c6dc3c082f3b...

Powered by Google App Engine
This is Rietveld 408576698