Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp

Issue 2835103002: Move blobalizer implementation to ShapeResultBloberizer (Closed)
Patch Set: Fix canvas tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp b/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp
index bbec6556cced0a801488e49208a08559897f3c2a..47d4c12278aaaaf5748c5aead242b8707d5f4226 100644
--- a/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp
+++ b/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaper.cpp
@@ -88,22 +88,10 @@ int CachingWordShaper::OffsetForPosition(const TextRun& run,
return buffer.OffsetForPosition(run, target_x, include_partial_glyphs);
}
-float CachingWordShaper::FillGlyphs(const TextRunPaintInfo& run_info,
- ShapeResultBloberizer& bloberizer) {
- ShapeResultBuffer buffer;
- ShapeResultsForRun(GetShapeCache(), &font_, run_info.run, &buffer);
-
- return buffer.FillGlyphs(run_info, bloberizer);
-}
-
-void CachingWordShaper::FillTextEmphasisGlyphs(
- const TextRunPaintInfo& run_info,
- const GlyphData& emphasis_data,
- ShapeResultBloberizer& bloberizer) {
- ShapeResultBuffer buffer;
- ShapeResultsForRun(GetShapeCache(), &font_, run_info.run, &buffer);
-
- buffer.FillTextEmphasisGlyphs(run_info, emphasis_data, bloberizer);
+void CachingWordShaper::FillResultBuffer(const TextRunPaintInfo& run_info,
+ ShapeResultBuffer* buffer) {
+ DCHECK(buffer);
+ ShapeResultsForRun(GetShapeCache(), &font_, run_info.run, buffer);
}
CharacterRange CachingWordShaper::GetCharacterRange(const TextRun& run,

Powered by Google App Engine
This is Rietveld 408576698