Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3306)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionTemplate.h

Issue 2835063002: Selection API: type attribute should return 'Range' for range-selection in text controls. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SelectionTemplate.h
diff --git a/third_party/WebKit/Source/core/editing/SelectionTemplate.h b/third_party/WebKit/Source/core/editing/SelectionTemplate.h
index 3fd2253b7fd89d4b3988ca80a44dc990d42babea..960748f12faa67b3a8605ffae0ba81c5316e3cb8 100644
--- a/third_party/WebKit/Source/core/editing/SelectionTemplate.h
+++ b/third_party/WebKit/Source/core/editing/SelectionTemplate.h
@@ -88,11 +88,11 @@ class CORE_EXPORT SelectionTemplate final {
TextAffinity Affinity() const { return affinity_; }
TextGranularity Granularity() const { return granularity_; }
bool HasTrailingWhitespace() const { return has_trailing_whitespace_; }
- bool IsCaret() const { return base_.IsNotNull() && base_ == extent_; }
+ bool IsCaret() const;
bool IsDirectional() const { return is_directional_; }
bool IsHandleVisible() const { return is_handle_visible_; }
bool IsNone() const { return base_.IsNull(); }
- bool IsRange() const { return base_ != extent_; }
+ bool IsRange() const;
// Returns true if |this| selection holds valid values otherwise it causes
// assertion failure.
« no previous file with comments | « third_party/WebKit/Source/core/editing/DOMSelection.cpp ('k') | third_party/WebKit/Source/core/editing/SelectionTemplate.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698