Hide proxy settings when not connected at network select screen

Hide proxy settings when not connected at network select screen

The 'Proxy settings' item will not trigger anything upon clicked when the
device is not connected to network, but it's still visible in the drop
down menu. It should be hidden until connected to network, consistent
with the old network select screen.

BUG=713144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2834963002
Cr-Commit-Position: refs/heads/master@{#466544}
Committed: https://chromium.googlesource.com/chromium/src/+/63128d6f67866fb126cc8043b6a4400133a67d4b

[Wenzhao (Colin) Zang, 2017-04-22 02:00:09]

Description was changed from

==========
Hide proxy settings when not connected to a network at network select screen

BUG=713144
==========

to

==========
Hide proxy settings when not connected to a network at network select screen

BUG=713144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Wenzhao (Colin) Zang, 2017-04-22 02:05:43]

Description was changed from

==========
Hide proxy settings when not connected to a network at network select screen

BUG=713144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Hide proxy settings when not connected at network select screen

The 'Proxy settings' item will not trigger anything upon clicked when the device
is not connected to network, but it's still visible which might be confusing. It
should be hidden until connected to network, consistent with the old network
select screen.

BUG=713144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Wenzhao (Colin) Zang, 2017-04-22 02:06:00]

Description was changed from

==========
Hide proxy settings when not connected at network select screen

The 'Proxy settings' item will not trigger anything upon clicked when the device
is not connected to network, but it's still visible which might be confusing. It
should be hidden until connected to network, consistent with the old network
select screen.

BUG=713144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Hide proxy settings when not connected at network select screen

The 'Proxy settings' item will not trigger anything upon clicked when the
device is not connected to network, but it's still visible which might be
confusing. It should be hidden until connected to network, consistent with
the old network select screen.

BUG=713144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Wenzhao (Colin) Zang, 2017-04-22 02:06:23]

wzang@chromium.org changed reviewers:
+ alemate@chromium.org

[Wenzhao (Colin) Zang, 2017-04-22 02:07:42]

Description was changed from

==========
Hide proxy settings when not connected at network select screen

The 'Proxy settings' item will not trigger anything upon clicked when the
device is not connected to network, but it's still visible which might be
confusing. It should be hidden until connected to network, consistent with
the old network select screen.

BUG=713144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Hide proxy settings when not connected at network select screen

The 'Proxy settings' item will not trigger anything upon clicked when the
device is not connected to network, but it's still visible in the dropdown menu.
It should be hidden until connected to network, consistent with the old network
select screen.

BUG=713144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Wenzhao (Colin) Zang, 2017-04-22 02:07:52]

Description was changed from

==========
Hide proxy settings when not connected at network select screen

The 'Proxy settings' item will not trigger anything upon clicked when the
device is not connected to network, but it's still visible in the dropdown menu.
It should be hidden until connected to network, consistent with the old network
select screen.

BUG=713144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Hide proxy settings when not connected at network select screen

The 'Proxy settings' item will not trigger anything upon clicked when the
device is not connected to network, but it's still visible in the drop down 
menu. It should be hidden until connected to network, consistent with the old
network select screen.

BUG=713144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Wenzhao (Colin) Zang, 2017-04-22 02:08:11]

Description was changed from

==========
Hide proxy settings when not connected at network select screen

The 'Proxy settings' item will not trigger anything upon clicked when the
device is not connected to network, but it's still visible in the drop down 
menu. It should be hidden until connected to network, consistent with the old
network select screen.

BUG=713144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Hide proxy settings when not connected at network select screen

The 'Proxy settings' item will not trigger anything upon clicked when the
device is not connected to network, but it's still visible in the drop down
menu. It should be hidden until connected to network, consistent
with the old network select screen.

BUG=713144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Wenzhao (Colin) Zang, 2017-04-22 02:08:35]

Description was changed from

==========
Hide proxy settings when not connected at network select screen

The 'Proxy settings' item will not trigger anything upon clicked when the
device is not connected to network, but it's still visible in the drop down
menu. It should be hidden until connected to network, consistent
with the old network select screen.

BUG=713144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Hide proxy settings when not connected at network select screen

The 'Proxy settings' item will not trigger anything upon clicked when the
device is not connected to network, but it's still visible in the drop
down menu. It should be hidden until connected to network, consistent
with the old network select screen.

BUG=713144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Alexander Alekseev, 2017-04-22 04:38:58]

lgtm

[Wenzhao (Colin) Zang, 2017-04-22 06:41:53]

The CQ bit was checked by wzang@chromium.org

[commit-bot: I haz the power, 2017-04-22 06:41:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-22 19:16:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492843313380780, "parent_rev":
"bd57430f53d31aa3ca7c4c28f7189667feb04908", "commit_rev":
"63128d6f67866fb126cc8043b6a4400133a67d4b"}

[commit-bot: I haz the power, 2017-04-22 19:16:45]

Description was changed from

==========
Hide proxy settings when not connected at network select screen

The 'Proxy settings' item will not trigger anything upon clicked when the
device is not connected to network, but it's still visible in the drop
down menu. It should be hidden until connected to network, consistent
with the old network select screen.

BUG=713144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Hide proxy settings when not connected at network select screen

The 'Proxy settings' item will not trigger anything upon clicked when the
device is not connected to network, but it's still visible in the drop
down menu. It should be hidden until connected to network, consistent
with the old network select screen.

BUG=713144
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2834963002
Cr-Commit-Position: refs/heads/master@{#466544}
Committed:
https://chromium.googlesource.com/chromium/src/+/63128d6f67866fb126cc8043b6a4...
==========

[commit-bot: I haz the power, 2017-04-22 19:16:46]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/63128d6f67866fb126cc8043b6a4...