Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: chrome/browser/resources/chromeos/login/oobe_welcome.js

Issue 2834963002: Hide proxy settings when not connected at network select screen (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/login/oobe_welcome.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/login/oobe_welcome.js
diff --git a/chrome/browser/resources/chromeos/login/oobe_welcome.js b/chrome/browser/resources/chromeos/login/oobe_welcome.js
index 9bf848887df9c170a1eb1e1ec6ada270060cf61d..aeaba1a63b61b01e7d01a541a52fe440aeee76c6 100644
--- a/chrome/browser/resources/chromeos/login/oobe_welcome.js
+++ b/chrome/browser/resources/chromeos/login/oobe_welcome.js
@@ -196,12 +196,13 @@ Polymer({
},
/**
- * Returns custom items for network selector.
+ * Returns custom items for network selector. Shows 'Proxy settings' only
+ * when connected to a network.
* @private
*/
- getNetworkCustomItems_: function() {
+ getNetworkCustomItems_: function(isConnected_) {
var self = this;
- return [
+ var items = [
{
customItemName: 'proxySettingsMenuName',
polymerIcon: 'oobe-welcome-20:add-proxy',
@@ -224,6 +225,9 @@ Polymer({
},
},
];
+ if (isConnected_)
+ return items;
+ return items.slice(1);
},
/**
« no previous file with comments | « chrome/browser/resources/chromeos/login/oobe_welcome.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698