Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2834783004: Add comment against usage of base::Thread. (Closed)

Created:
3 years, 8 months ago by fdoray
Modified:
3 years, 8 months ago
Reviewers:
gab
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add comment against usage of base::Thread. base::Create(Sequenced|SingleTreaded)TaskRunnerWithTraits() should cover most use cases of base::Thread. R=gab@chromium.org BUG= Review-Url: https://codereview.chromium.org/2834783004 Cr-Commit-Position: refs/heads/master@{#467005} Committed: https://chromium.googlesource.com/chromium/src/+/9a6a64f2c851a4bde4ab9e09b2743a7f2d97edf2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M base/threading/thread.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
fdoray
PTAL
3 years, 8 months ago (2017-04-21 20:42:21 UTC) #1
gab
lgtm
3 years, 8 months ago (2017-04-25 14:22:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834783004/1
3 years, 8 months ago (2017-04-25 14:22:25 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 16:17:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9a6a64f2c851a4bde4ab9e09b274...

Powered by Google App Engine
This is Rietveld 408576698