Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3108)

Unified Diff: base/threading/thread.h

Issue 2834783004: Add comment against usage of base::Thread. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/threading/thread.h
diff --git a/base/threading/thread.h b/base/threading/thread.h
index 01f7d8e250c7ef6ca241618d3ceb36fbb790d69e..2db69c2148019ad3c666d001524344dc45ce1ce2 100644
--- a/base/threading/thread.h
+++ b/base/threading/thread.h
@@ -28,6 +28,9 @@ namespace base {
class MessagePump;
class RunLoop;
+// IMPORTANT: Instead of creating a base::Thread, consider using
+// base::Create(Sequenced|SingleTreaded)TaskRunnerWithTraits().
+//
// A simple thread abstraction that establishes a MessageLoop on a new thread.
// The consumer uses the MessageLoop of the thread to cause code to execute on
// the thread. When this object is destroyed the thread is terminated. All
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698