Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2834783002: window.print() should close form validation bubble. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 666 matching lines...) Expand 10 before | Expand all | Expand 10 after
677 did_request_non_empty_tool_tip_ = false; 677 did_request_non_empty_tool_tip_ = false;
678 } 678 }
679 } 679 }
680 680
681 void ChromeClientImpl::DispatchViewportPropertiesDidChange( 681 void ChromeClientImpl::DispatchViewportPropertiesDidChange(
682 const ViewportDescription& description) const { 682 const ViewportDescription& description) const {
683 web_view_->UpdatePageDefinedViewportConstraints(description); 683 web_view_->UpdatePageDefinedViewportConstraints(description);
684 } 684 }
685 685
686 void ChromeClientImpl::PrintDelegate(LocalFrame* frame) { 686 void ChromeClientImpl::PrintDelegate(LocalFrame* frame) {
687 NotifyPopupOpeningObservers();
687 if (web_view_->Client()) 688 if (web_view_->Client())
688 web_view_->Client()->PrintPage(WebLocalFrameImpl::FromFrame(frame)); 689 web_view_->Client()->PrintPage(WebLocalFrameImpl::FromFrame(frame));
689 } 690 }
690 691
691 ColorChooser* ChromeClientImpl::OpenColorChooser( 692 ColorChooser* ChromeClientImpl::OpenColorChooser(
692 LocalFrame* frame, 693 LocalFrame* frame,
693 ColorChooserClient* chooser_client, 694 ColorChooserClient* chooser_client,
694 const Color&) { 695 const Color&) {
695 NotifyPopupOpeningObservers(); 696 NotifyPopupOpeningObservers();
696 ColorChooserUIController* controller = nullptr; 697 ColorChooserUIController* controller = nullptr;
(...skipping 537 matching lines...) Expand 10 before | Expand all | Expand 10 after
1234 if (RuntimeEnabledFeatures::presentationEnabled()) 1235 if (RuntimeEnabledFeatures::presentationEnabled())
1235 PresentationController::ProvideTo(frame, client->PresentationClient()); 1236 PresentationController::ProvideTo(frame, client->PresentationClient());
1236 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) { 1237 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) {
1237 ProvideAudioOutputDeviceClientTo(frame, 1238 ProvideAudioOutputDeviceClientTo(frame,
1238 new AudioOutputDeviceClientImpl(frame)); 1239 new AudioOutputDeviceClientImpl(frame));
1239 } 1240 }
1240 InstalledAppController::ProvideTo(frame, client->GetRelatedAppsFetcher()); 1241 InstalledAppController::ProvideTo(frame, client->GetRelatedAppsFetcher());
1241 } 1242 }
1242 1243
1243 } // namespace blink 1244 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | third_party/WebKit/Source/web/ValidationMessageClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698