Mus Browser Tests

Mus Browser Tests

This change modifies MashBrowserTestsMain and MojoTestConnector in order to
support also running with the flag "--run-in-mus".

Additionally the build configuration for mus_browser_tests_catalog lists a
smaller subset of supported services than mash_browser_tests_catalog. To align
with differences between --mash and --mus

This change does not include any enabling on trybots. A subsequent change will
first enable on FYI bots, then later on directly on the main trybots.

TEST=mus_browser_tests, mash_browser_tests
BUG=705716
Review-Url: https://codereview.chromium.org/2834693002
Cr-Commit-Position: refs/heads/master@{#466338}
Committed: https://chromium.googlesource.com/chromium/src/+/e3fba3aea86a7aa5292cdd01bc133cd98a363135

[jonross, 2017-04-20 18:28:21]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2017-04-20 18:28:22]

Hey sky@

Could you look at this review which enables running browser_tests with
--run-in-mash locally.

Thanks,
Jon

[sky, 2017-04-20 20:52:58]

LGTM

https://codereview.chromium.org/2834693002/diff/1/chrome/test/base/mojo_test_...
File chrome/test/base/mojo_test_connector.cc (right):

https://codereview.chromium.org/2834693002/diff/1/chrome/test/base/mojo_test_...
chrome/test/base/mojo_test_connector.cc:54: std::string mus_config_switch) {
const std::string&

https://codereview.chromium.org/2834693002/diff/1/chrome/test/base/mojo_test_...
chrome/test/base/mojo_test_connector.cc:155: explicit
ServiceProcessLauncherDelegateImpl(std::string test_runner_name)
const std::string&

https://codereview.chromium.org/2834693002/diff/1/chrome/test/base/mojo_test_...
chrome/test/base/mojo_test_connector.cc:182: std::string test_runner_name_;
const

https://codereview.chromium.org/2834693002/diff/1/chrome/test/base/mojo_test_...
File chrome/test/base/mojo_test_connector.h (right):

https://codereview.chromium.org/2834693002/diff/1/chrome/test/base/mojo_test_...
chrome/test/base/mojo_test_connector.h:56: explicit
MojoTestConnector(std::unique_ptr<base::Value> catalog_contents,
remove explicit

https://codereview.chromium.org/2834693002/diff/1/chrome/test/base/mojo_test_...
chrome/test/base/mojo_test_connector.h:70: Config config_;
const

[jonross, 2017-04-21 14:04:14]

The CQ bit was checked by jonross@chromium.org

[jonross, 2017-04-21 14:04:15]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2834693002/#ps20001
(title: "Address Comments")

[jonross, 2017-04-21 14:04:22]

https://codereview.chromium.org/2834693002/diff/1/chrome/test/base/mojo_test_...
File chrome/test/base/mojo_test_connector.cc (right):

https://codereview.chromium.org/2834693002/diff/1/chrome/test/base/mojo_test_...
chrome/test/base/mojo_test_connector.cc:54: std::string mus_config_switch) {
On 2017/04/20 20:52:58, sky wrote:
> const std::string&

Done.

https://codereview.chromium.org/2834693002/diff/1/chrome/test/base/mojo_test_...
chrome/test/base/mojo_test_connector.cc:155: explicit
ServiceProcessLauncherDelegateImpl(std::string test_runner_name)
On 2017/04/20 20:52:58, sky wrote:
> const std::string&

Done.

https://codereview.chromium.org/2834693002/diff/1/chrome/test/base/mojo_test_...
chrome/test/base/mojo_test_connector.cc:182: std::string test_runner_name_;
On 2017/04/20 20:52:58, sky wrote:
> const

Done.

https://codereview.chromium.org/2834693002/diff/1/chrome/test/base/mojo_test_...
File chrome/test/base/mojo_test_connector.h (right):

https://codereview.chromium.org/2834693002/diff/1/chrome/test/base/mojo_test_...
chrome/test/base/mojo_test_connector.h:56: explicit
MojoTestConnector(std::unique_ptr<base::Value> catalog_contents,
On 2017/04/20 20:52:58, sky wrote:
> remove explicit

Done.

https://codereview.chromium.org/2834693002/diff/1/chrome/test/base/mojo_test_...
chrome/test/base/mojo_test_connector.h:70: Config config_;
On 2017/04/20 20:52:58, sky wrote:
> const

Done.

[commit-bot: I haz the power, 2017-04-21 14:04:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 15:06:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492783454682370,
"parent_rev": "c81c13ac449b26b113f79c4b1155f21976724bd9", "commit_rev":
"e3fba3aea86a7aa5292cdd01bc133cd98a363135"}

[commit-bot: I haz the power, 2017-04-21 15:06:43]

Description was changed from

==========
Mus Browser Tests

This change modifies MashBrowserTestsMain and MojoTestConnector in order to
support also running with the flag "--run-in-mus".

Additionally the build configuration for mus_browser_tests_catalog lists a
smaller subset of supported services than mash_browser_tests_catalog. To align
with differences between --mash and --mus

This change does not include any enabling on trybots. A subsequent change will
first enable on FYI bots, then later on directly on the main trybots.

TEST=mus_browser_tests, mash_browser_tests
BUG=705716
==========

to

==========
Mus Browser Tests

This change modifies MashBrowserTestsMain and MojoTestConnector in order to
support also running with the flag "--run-in-mus".

Additionally the build configuration for mus_browser_tests_catalog lists a
smaller subset of supported services than mash_browser_tests_catalog. To align
with differences between --mash and --mus

This change does not include any enabling on trybots. A subsequent change will
first enable on FYI bots, then later on directly on the main trybots.

TEST=mus_browser_tests, mash_browser_tests
BUG=705716

Review-Url: https://codereview.chromium.org/2834693002
Cr-Commit-Position: refs/heads/master@{#466338}
Committed:
https://chromium.googlesource.com/chromium/src/+/e3fba3aea86a7aa5292cdd01bc13...
==========

[commit-bot: I haz the power, 2017-04-21 15:06:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e3fba3aea86a7aa5292cdd01bc13...