Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: chrome/test/base/mojo_test_connector.h

Issue 2834693002: Mus Browser Tests (Closed)
Patch Set: Address Comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/mash_browser_tests_main.cc ('k') | chrome/test/base/mojo_test_connector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/mojo_test_connector.h
diff --git a/chrome/test/base/mojo_test_connector.h b/chrome/test/base/mojo_test_connector.h
index abaf89ce5acba8c5d1bd7b4763232142ed9f8624..6c9b565994ba8e52c2bc31b447179b83613f6f28 100644
--- a/chrome/test/base/mojo_test_connector.h
+++ b/chrome/test/base/mojo_test_connector.h
@@ -42,7 +42,19 @@ class MojoTestConnector {
// browser_tests.
static const char kMashApp[];
- explicit MojoTestConnector(std::unique_ptr<base::Value> catalog_contents);
+ // Enumeration of the possible chrome-ash configurations supported by this
+ // test.
+ enum class Config {
+ // Aura is backed by mus, but chrome and ash are still in the same process.
+ MUS,
+
+ // Aura is backed by mus and chrome and ash are in separate processes. In
+ // this mode chrome code can only use ash code in ash/public/cpp.
+ MASH,
+ };
+
+ MojoTestConnector(std::unique_ptr<base::Value> catalog_contents,
+ Config config);
~MojoTestConnector();
// Initializes the background thread the ServiceManager runs on.
@@ -55,6 +67,8 @@ class MojoTestConnector {
private:
class ServiceProcessLauncherDelegateImpl;
+ const Config config_;
+
std::unique_ptr<ServiceProcessLauncherDelegateImpl>
service_process_launcher_delegate_;
std::unique_ptr<service_manager::BackgroundServiceManager>
« no previous file with comments | « chrome/test/base/mash_browser_tests_main.cc ('k') | chrome/test/base/mojo_test_connector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698