Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2834683002: Merge M59 [WebAPKs] Fix WebAPK updates when Web Manifest does not specify color (Closed)

Created:
3 years, 8 months ago by pkotwicz
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Merge M59 [WebAPKs] Fix WebAPK updates when Web Manifest does not specify color content::Manifest::kInvalidOrMissingColor has a value which takes up more than 32 bits. This CL fixes truncation to 32 bits which was occurring in webapk_update_manager.cc sizeof(long) = 4 sizeof(int64_t) = 8 BUG=711519 Review-Url: https://codereview.chromium.org/2822623002 Cr-Commit-Position: refs/heads/master@{#465745} (cherry picked from commit c751fcc699b1d5e905870e62f453b326195e55e9) Review-Url: https://codereview.chromium.org/2834683002 . Cr-Commit-Position: refs/branch-heads/3071@{#88} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/e5b9695a7dc917cb2ee3405d03503ec24be381d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/android/webapk/webapk_update_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
pkotwicz
3 years, 8 months ago (2017-04-20 17:59:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e5b9695a7dc917cb2ee3405d03503ec24be381d3.

Powered by Google App Engine
This is Rietveld 408576698