Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2822623002: [WebAPKs] Fix WebAPK updates when Web Manifest does not specify color (Closed)

Created:
3 years, 8 months ago by pkotwicz
Modified:
3 years, 8 months ago
Reviewers:
dominickn, Xi Han
CC:
chromium-reviews, zpeng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebAPKs] Fix WebAPK updates when Web Manifest does not specify color content::Manifest::kInvalidOrMissingColor has a value which takes up more than 32 bits. This CL fixes truncation to 32 bits which was occurring in webapk_update_manager.cc sizeof(long) = 4 sizeof(int64_t) = 8 BUG=711519 Review-Url: https://codereview.chromium.org/2822623002 Cr-Commit-Position: refs/heads/master@{#465745} Committed: https://chromium.googlesource.com/chromium/src/+/c751fcc699b1d5e905870e62f453b326195e55e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/android/webapk/webapk_update_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
pkotwicz
Xi, can you please take a look?
3 years, 8 months ago (2017-04-14 01:01:54 UTC) #2
Xi Han
lgtm
3 years, 8 months ago (2017-04-14 01:16:51 UTC) #3
pkotwicz
Dominick, can you please take a look?
3 years, 8 months ago (2017-04-18 18:46:56 UTC) #5
dominickn
lgtm
3 years, 8 months ago (2017-04-18 23:54:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822623002/1
3 years, 8 months ago (2017-04-19 20:26:53 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 21:05:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c751fcc699b1d5e905870e62f453...

Powered by Google App Engine
This is Rietveld 408576698