Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2834583005: Fix box-shadow painting for fieldset with legend, background, and border-radius (Closed)

Created:
3 years, 8 months ago by Xianzhu
Modified:
3 years, 8 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Fix box-shadow painting for fieldset with legend, background, and border-radius This regressed since https://codereview.chromium.org/2464053003 which separated box-shadow painting from background painting, but missed modification to FieldsetPainter about box-shadow/background painting. BUG=713331 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2836673002 Cr-Commit-Position: refs/heads/master@{#466441} TBR=wangxianzhu@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2834583005 Cr-Commit-Position: refs/branch-heads/3071@{#133} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/6fdc7c8a7d3dca558b11a7a0c23cef196d63ef9b

Patch Set 1 #

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834583005/1
3 years, 8 months ago (2017-04-21 22:45:38 UTC) #2
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 22:47:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6fdc7c8a7d3dca558b11a7a0c23c...

Powered by Google App Engine
This is Rietveld 408576698