Fix box-shadow painting for fieldset with legend, background, and border-radius

Fix box-shadow painting for fieldset with legend, background, and border-radius

This regressed since https://codereview.chromium.org/2464053003
which separated box-shadow painting from background painting, but
missed modification to FieldsetPainter about box-shadow/background
painting.

BUG=713331
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2836673002
Cr-Commit-Position: refs/heads/master@{#466441}
Committed: https://chromium.googlesource.com/chromium/src/+/7d8aac7b2e42174063748f68741f2a681df2e7b9

[Xianzhu, 2017-04-21 16:36:21]

Description was changed from

==========
Fix box-shadow painting for fieldset with legend, background, and border-radius

This regressed since https://codereview.chromium.org/2464053003
which separated box-shadow painting from background painting, but
missed modification to FieldsetPainter about box-shadow/background
painting.

BUG=713331
==========

to

==========
Fix box-shadow painting for fieldset with legend, background, and border-radius

This regressed since https://codereview.chromium.org/2464053003
which separated box-shadow painting from background painting, but
missed modification to FieldsetPainter about box-shadow/background
painting.

BUG=713331
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-04-21 16:36:24]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[Xianzhu, 2017-04-21 16:36:40]

wangxianzhu@chromium.org changed reviewers:
+ wkorman@chromium.org

[commit-bot: I haz the power, 2017-04-21 16:36:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wkorman, 2017-04-21 17:00:20]

lgtm

https://codereview.chromium.org/2836673002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/FieldsetPainter.cpp (left):

https://codereview.chromium.org/2836673002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/FieldsetPainter.cpp:52: if
(box_decoration_data.bleed_avoidance == kBackgroundBleedNone) {
After removing this usage of bleed_avoidance, it looks like the only remaining
reads are in BoxBorderPainter DrawBleedAdjustedDRRect and
BleedAvoidanceIsClipping. They look like they're still useful, but perhaps worth
reviewing those separately to see if they could be removed at some point.

[Xianzhu, 2017-04-21 17:31:14]

https://codereview.chromium.org/2836673002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/FieldsetPainter.cpp (left):

https://codereview.chromium.org/2836673002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/FieldsetPainter.cpp:52: if
(box_decoration_data.bleed_avoidance == kBackgroundBleedNone) {
On 2017/04/21 17:00:20, wkorman wrote:
> After removing this usage of bleed_avoidance, it looks like the only remaining
> reads are in BoxBorderPainter DrawBleedAdjustedDRRect and
> BleedAvoidanceIsClipping. They look like they're still useful, but perhaps
worth
> reviewing those separately to see if they could be removed at some point.

Filed a task bug crbug.com/714186 for it.

[commit-bot: I haz the power, 2017-04-21 18:04:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 18:04:53]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2017-04-21 20:52:01]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-04-21 20:52:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 20:56:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492807921361810, "parent_rev":
"5a589220480eef0ce8436e3bdd00c796d914a596", "commit_rev":
"7d8aac7b2e42174063748f68741f2a681df2e7b9"}

[commit-bot: I haz the power, 2017-04-21 20:56:36]

Description was changed from

==========
Fix box-shadow painting for fieldset with legend, background, and border-radius

This regressed since https://codereview.chromium.org/2464053003
which separated box-shadow painting from background painting, but
missed modification to FieldsetPainter about box-shadow/background
painting.

BUG=713331
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix box-shadow painting for fieldset with legend, background, and border-radius

This regressed since https://codereview.chromium.org/2464053003
which separated box-shadow painting from background painting, but
missed modification to FieldsetPainter about box-shadow/background
painting.

BUG=713331
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2836673002
Cr-Commit-Position: refs/heads/master@{#466441}
Committed:
https://chromium.googlesource.com/chromium/src/+/7d8aac7b2e42174063748f68741f...
==========

[commit-bot: I haz the power, 2017-04-21 20:56:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7d8aac7b2e42174063748f68741f...