Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2836673002: Fix box-shadow painting for fieldset with legend, background, and border-radius (Closed)

Created:
3 years, 8 months ago by Xianzhu
Modified:
3 years, 8 months ago
Reviewers:
wkorman
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix box-shadow painting for fieldset with legend, background, and border-radius This regressed since https://codereview.chromium.org/2464053003 which separated box-shadow painting from background painting, but missed modification to FieldsetPainter about box-shadow/background painting. BUG=713331 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2836673002 Cr-Commit-Position: refs/heads/master@{#466441} Committed: https://chromium.googlesource.com/chromium/src/+/7d8aac7b2e42174063748f68741f2a681df2e7b9

Patch Set 1 #

Total comments: 2

Messages

Total messages: 14 (9 generated)
Xianzhu
3 years, 8 months ago (2017-04-21 16:36:40 UTC) #4
wkorman
lgtm https://codereview.chromium.org/2836673002/diff/1/third_party/WebKit/Source/core/paint/FieldsetPainter.cpp File third_party/WebKit/Source/core/paint/FieldsetPainter.cpp (left): https://codereview.chromium.org/2836673002/diff/1/third_party/WebKit/Source/core/paint/FieldsetPainter.cpp#oldcode52 third_party/WebKit/Source/core/paint/FieldsetPainter.cpp:52: if (box_decoration_data.bleed_avoidance == kBackgroundBleedNone) { After removing this ...
3 years, 8 months ago (2017-04-21 17:00:20 UTC) #6
Xianzhu
https://codereview.chromium.org/2836673002/diff/1/third_party/WebKit/Source/core/paint/FieldsetPainter.cpp File third_party/WebKit/Source/core/paint/FieldsetPainter.cpp (left): https://codereview.chromium.org/2836673002/diff/1/third_party/WebKit/Source/core/paint/FieldsetPainter.cpp#oldcode52 third_party/WebKit/Source/core/paint/FieldsetPainter.cpp:52: if (box_decoration_data.bleed_avoidance == kBackgroundBleedNone) { On 2017/04/21 17:00:20, wkorman ...
3 years, 8 months ago (2017-04-21 17:31:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836673002/1
3 years, 8 months ago (2017-04-21 20:52:25 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 20:56:37 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7d8aac7b2e42174063748f68741f...

Powered by Google App Engine
This is Rietveld 408576698