Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1633)

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5

Issue 2834583004: Use generated copy and compare for VerticalAlign in ComputedStyle. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
diff --git a/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 b/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
index d9eb365dfedf239342d382e5def8a425cbd15610..a58f7560198f6eda01ac82eab91a435d4024b78d 100644
--- a/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
+++ b/third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5
@@ -153,7 +153,7 @@
has_custom_compare_and_copy: true,
},
// TODO(shend): vertical align is actually a CSS property, but since we don't support union fields
- // which can be either a keyword or Length, this is generated as a nonproperty for now. Remove this
+ // which can be either a keyword or Length, this is generated in this file for now. Remove this
Bugs Nash 2017/04/24 00:33:42 Please add to this comment where in this file (fun
shend 2017/04/24 00:43:50 Oops, the comment is misleading. Changed.
// once we can support union fields and groups.
{
name: "VerticalAlign",
@@ -161,7 +161,6 @@
field_size: 4,
default_value: "EVerticalAlign::kBaseline",
type_name: "EVerticalAlign",
- has_custom_compare_and_copy: true,
},
],
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698