Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2834583004: Use generated copy and compare for VerticalAlign in ComputedStyle. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index b222b4f2a2df73a515b9d9e35601b80403fbe0ad..504d0e3bd9275540c75eb09679e3e0c35dce6d9f 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -344,7 +344,6 @@ void ComputedStyle::CopyNonInheritedFromCached(const ComputedStyle& other) {
// See comments for each skipped flag below.
// These are not generated in ComputedStyleBase
- SetVerticalAlign(other.VerticalAlign());
SetHasViewportUnits(other.HasViewportUnits());
SetHasRemUnitsInternal(other.HasRemUnits());
@@ -477,8 +476,6 @@ bool ComputedStyle::LoadingCustomFontsEqual(const ComputedStyle& other) const {
bool ComputedStyle::NonInheritedEqual(const ComputedStyle& other) const {
// compare everything except the pseudoStyle pointer
return ComputedStyleBase::NonInheritedEqual(other) &&
- VerticalAlign() == other.VerticalAlign() && // Not generated in
- // ComputedStyleBase
box_ == other.box_ &&
visual_ == other.visual_ && background_ == other.background_ &&
surround_ == other.surround_ &&

Powered by Google App Engine
This is Rietveld 408576698