Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Side by Side Diff: third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5

Issue 2834583004: Use generated copy and compare for VerticalAlign in ComputedStyle. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 // This file specifies fields in ComputedStyle that we would like to 2 // This file specifies fields in ComputedStyle that we would like to
3 // generate, but are not CSS properties. 3 // generate, but are not CSS properties.
4 4
5 parameters: { 5 parameters: {
6 // - field_size 6 // - field_size
7 // Number of bits needed to store this field. Only used for storage_only 7 // Number of bits needed to store this field. Only used for storage_only
8 // fields. If specified, the field will be stored as bit field. Otherwise 8 // fields. If specified, the field will be stored as bit field. Otherwise
9 // it will be stored as a normal data member. 9 // it will be stored as a normal data member.
10 field_size: { 10 field_size: {
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 { 146 {
147 name: "HasSimpleUnderline", 147 name: "HasSimpleUnderline",
148 field_template: "storage_only", 148 field_template: "storage_only",
149 field_size: 1, 149 field_size: 1,
150 default_value: "false", 150 default_value: "false",
151 type_name: "bool", 151 type_name: "bool",
152 inherited: true, 152 inherited: true,
153 has_custom_compare_and_copy: true, 153 has_custom_compare_and_copy: true,
154 }, 154 },
155 // TODO(shend): vertical align is actually a CSS property, but since we don' t support union fields 155 // TODO(shend): vertical align is actually a CSS property, but since we don' t support union fields
156 // which can be either a keyword or Length, this is generated as a nonproper ty for now. Remove this 156 // which can be either a keyword or Length, this is generated in this file f or now. Remove this
Bugs Nash 2017/04/24 00:33:42 Please add to this comment where in this file (fun
shend 2017/04/24 00:43:50 Oops, the comment is misleading. Changed.
157 // once we can support union fields and groups. 157 // once we can support union fields and groups.
158 { 158 {
159 name: "VerticalAlign", 159 name: "VerticalAlign",
160 field_template: "storage_only", 160 field_template: "storage_only",
161 field_size: 4, 161 field_size: 4,
162 default_value: "EVerticalAlign::kBaseline", 162 default_value: "EVerticalAlign::kBaseline",
163 type_name: "EVerticalAlign", 163 type_name: "EVerticalAlign",
164 has_custom_compare_and_copy: true,
165 }, 164 },
166 ], 165 ],
167 } 166 }
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698