Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2834573004: [i18n] escape commas, polymer workaround (Closed)

Created:
3 years, 8 months ago by dschuyler
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[i18n] escape commas, polymer workaround The Polymer binding parser treats commas and escaped commas as special. This CL escapes commas so they are handled properly with Polymer. (Without this CL the binding is ignored if an un-escaped comma is present). BUG=705850 Review-Url: https://codereview.chromium.org/2818053002 Cr-Commit-Position: refs/heads/master@{#464753} (cherry picked from commit cdf55422a65db1c91c48ba50e952f9a1804bbb1a) Review-Url: https://codereview.chromium.org/2834573004 . Cr-Commit-Position: refs/branch-heads/3071@{#92} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/0419a2b67cc65c1b1dd462c2eeeaf0a25de87341

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/base/template_expressions.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dschuyler
3 years, 8 months ago (2017-04-20 18:39:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0419a2b67cc65c1b1dd462c2eeeaf0a25de87341.

Powered by Google App Engine
This is Rietveld 408576698