[i18n] escape commas, polymer workaround

[i18n] escape commas, polymer workaround

The Polymer binding parser treats commas and escaped commas as special.
This CL escapes commas so they are handled properly with Polymer.
(Without this CL the binding is ignored if an un-escaped comma is present).

BUG=705850
Review-Url: https://codereview.chromium.org/2818053002
Cr-Commit-Position: refs/heads/master@{#464753}
Committed: https://chromium.googlesource.com/chromium/src/+/cdf55422a65db1c91c48ba50e952f9a1804bbb1a

[dschuyler, 2017-04-14 00:53:43]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[dschuyler, 2017-04-14 00:54:04]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[commit-bot: I haz the power, 2017-04-14 00:54:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2017-04-14 00:57:34]

Description was changed from

==========
[i18n] escape commas, polymer workaround

The Polymer binding parser treats commas and escaped commas as special.
This CL escapes commas so they are handled properly with Polymer.
(Without this CL the binding is ignored).

BUG=705850
==========

to

==========
[i18n] escape commas, polymer workaround

The Polymer binding parser treats commas and escaped commas as special.
This CL escapes commas so they are handled properly with Polymer.
(Without this CL the binding is ignored if an un-escaped comma is present).

BUG=705850
==========

[dschuyler, 2017-04-14 01:01:19]

On 2017/04/14 00:54:04, dschuyler wrote:

I'll update the unit test in a follow up CL.

[dschuyler, 2017-04-14 01:01:21]

On 2017/04/14 00:54:04, dschuyler wrote:

I'll update the unit test in a follow up CL.

[dpapad, 2017-04-14 01:03:20]

LGTM

https://codereview.chromium.org/2818053002/diff/1/ui/base/template_expression...
File ui/base/template_expressions.cc (right):

https://codereview.chromium.org/2818053002/diff/1/ui/base/template_expression...
ui/base/template_expressions.cc:35: out.append("\\,");
FYI, escaping the commas seems to be expected by Polymer, even though not
documented anywhere (or anywhere I could find), see test case at
https://github.com/Polymer/polymer/blob/9997a049ef092c55d324881892f850f6154e3....

[commit-bot: I haz the power, 2017-04-14 02:38:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 02:38:21]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-04-14 18:09:12]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2017-04-14 18:09:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 18:15:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492193352267410, "parent_rev":
"be87179197a85107c1953022480f5284618b687f", "commit_rev":
"cdf55422a65db1c91c48ba50e952f9a1804bbb1a"}

[commit-bot: I haz the power, 2017-04-14 18:16:38]

Description was changed from

==========
[i18n] escape commas, polymer workaround

The Polymer binding parser treats commas and escaped commas as special.
This CL escapes commas so they are handled properly with Polymer.
(Without this CL the binding is ignored if an un-escaped comma is present).

BUG=705850
==========

to

==========
[i18n] escape commas, polymer workaround

The Polymer binding parser treats commas and escaped commas as special.
This CL escapes commas so they are handled properly with Polymer.
(Without this CL the binding is ignored if an un-escaped comma is present).

BUG=705850

Review-Url: https://codereview.chromium.org/2818053002
Cr-Commit-Position: refs/heads/master@{#464753}
Committed:
https://chromium.googlesource.com/chromium/src/+/cdf55422a65db1c91c48ba50e952...
==========

[commit-bot: I haz the power, 2017-04-14 18:16:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cdf55422a65db1c91c48ba50e952...