Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Issue 2834493005: DevTools: revert Persistence2.0 experiment by default. (Closed)

Created:
3 years, 8 months ago by lushnikov
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

DevTools: revert Persistence2.0 experiment by default. It turned out that Persistence2.0 doesn't account for the important usecase: develoers were using workspace feature to override hosted stylesheets. In this case, both Persistence2.0 and "prevalidateBindigns" experiments stay on their way: - Persistence2.0 doesn't allow to map files with different filenames - prevalidateBindings doesn't allow to map network resources to files if contents are different. This patch: - disables Persistence2.0 experiment by default - merges prevalidateBindings experiment into Persistence2.0 experiment The latter is important since binding prevalidation only necessary for Persistence2.0 to work properly. BUG=707002 R=dgozman Review-Url: https://codereview.chromium.org/2818713007 Cr-Commit-Position: refs/heads/master@{#465412} (cherry picked from commit 87e05d141b5b873725e95585e92f07a6b7ac1fb2) Review-Url: https://codereview.chromium.org/2834493005 . Cr-Commit-Position: refs/branch-heads/3071@{#100} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/cc83cecb8fa8b3385610f2dd893166acbedbd8da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteText.js View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
lushnikov
3 years, 8 months ago (2017-04-20 21:29:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cc83cecb8fa8b3385610f2dd893166acbedbd8da.

Powered by Google App Engine
This is Rietveld 408576698