Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2818713007: DevTools: revert Persistence2.0 experiment by default. (Closed)

Created:
3 years, 8 months ago by lushnikov
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: revert Persistence2.0 experiment by default. It turned out that Persistence2.0 doesn't account for the important usecase: develoers were using workspace feature to override hosted stylesheets. In this case, both Persistence2.0 and "prevalidateBindigns" experiments stay on their way: - Persistence2.0 doesn't allow to map files with different filenames - prevalidateBindings doesn't allow to map network resources to files if contents are different. This patch: - disables Persistence2.0 experiment by default - merges prevalidateBindings experiment into Persistence2.0 experiment The latter is important since binding prevalidation only necessary for Persistence2.0 to work properly. BUG=707002 R=dgozman Review-Url: https://codereview.chromium.org/2818713007 Cr-Commit-Position: refs/heads/master@{#465412} Committed: https://chromium.googlesource.com/chromium/src/+/87e05d141b5b873725e95585e92f07a6b7ac1fb2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteText.js View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
lushnikov
please, take a look
3 years, 8 months ago (2017-04-14 23:07:26 UTC) #2
dgozman
lgtm
3 years, 8 months ago (2017-04-15 01:45:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818713007/1
3 years, 8 months ago (2017-04-18 20:52:40 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 23:03:35 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/87e05d141b5b873725e95585e92f...

Powered by Google App Engine
This is Rietveld 408576698