third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.cpp - Issue 2834463002: Move CreateDOMException out of V8ThrowException

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.cpp

Issue 2834463002: Move CreateDOMException out of V8ThrowException (Closed)

Patch Set: Add comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp ('k') | third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.cpp

diff --git a/third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.cpp b/third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.cpp

index 14a533227277e554120e428b8d792bace4227f3a..fddc4282c15168ba8e69972ed4841e6c667dcbb1 100644

--- a/third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.cpp

+++ b/third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.cpp

@@ -6,7 +6,7 @@

#include "bindings/core/v8/ScriptPromise.h"

#include "bindings/core/v8/ScriptState.h"

-#include "bindings/core/v8/V8ThrowException.h"

+#include "bindings/core/v8/V8ThrowDOMException.h"

#include "core/dom/DOMException.h"

#include "core/dom/ExecutionContext.h"

#include "platform/wtf/Assertions.h"

@@ -95,7 +95,7 @@ void ContentDecryptionModuleResultPromise::Reject(ExceptionCode code,

ScriptState::Scope scope(resolver_->GetScriptState());

v8::Isolate* isolate = resolver_->GetScriptState()->GetIsolate();

resolver_->Reject(

- V8ThrowException::CreateDOMException(isolate, code, error_message));

+ V8ThrowDOMException::CreateDOMException(isolate, code, error_message));

resolver_.Clear();

}