[Sync] Update Type Info section of sync-internals.

[Sync] Update Type Info section of sync-internals.

* Added DataTypeController's State to sync-internals. This should make
debugging certain issues significantly easier.
* Stopped double requesting directory status counters.
* ModelSafeGroup's ToString is no longer SHOUTY_CAPS, but Captialized
Words to be in line with ModelType, and to allow sync-internals to put
line breaks between them.
* ModelSafeGroup's ToString no longer has a default clause, to force
new values to have handling added at compile time.
* Split up ModelSafeGroup and a status/health message into two separate
column on sync-internals.
* Updated javascript updating logic to apply status counters to
correctly write zeros.

BUG=714198
Review-Url: https://codereview.chromium.org/2834453006
Cr-Commit-Position: refs/heads/master@{#466486}
Committed: https://chromium.googlesource.com/chromium/src/+/0cfadad67cd27254cce5ae62891aab6f5fc1d643

[skym, 2017-04-21 17:59:26]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 17:59:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2017-04-21 18:00:37]

Description was changed from

==========
[Sync] Update Type Info section of sync-internals.

BUG=714198
==========

to

==========
[Sync] Update Type Info section of sync-internals.

* Added DataTypeController's State to sync-internals. This should make
debugging certain issues significantly easier.
* Stopped double requesting directory status counters.
* ModelSafeGroup's ToString is no longer SHOUTY_CAPS, but Captialized
Words to be in line with ModelType, and to allow sync-internals to put
line breaks between them.
* ModelSafeGroup's ToString no longer has a default clause, to force
new values to have handling added at compile time.
* Split up ModelSafeGroup and a status/health message into two separate
column on sync-internals.
* Updated javascript updating logic to apply status counters to
correctly write zeros.

BUG=714198
==========

[skym, 2017-04-21 18:00:37]

skym@chromium.org changed reviewers:
+ pavely@chromium.org

[skym, 2017-04-21 18:00:45]

PTAL

[commit-bot: I haz the power, 2017-04-21 18:28:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 18:28:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[skym, 2017-04-21 18:35:25]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 18:36:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 19:00:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 19:00:41]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[skym, 2017-04-21 19:27:48]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 19:28:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 20:28:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 20:28:18]

Dry run: This issue passed the CQ dry run.

[pavely, 2017-04-21 20:30:06]

lgtm

https://codereview.chromium.org/2834453006/diff/60001/components/browser_sync...
File components/browser_sync/profile_sync_service.cc (right):

https://codereview.chromium.org/2834453006/diff/60001/components/browser_sync...
components/browser_sync/profile_sync_service.cc:1788: ModelSafeRoutingInfo
routing_info;
With the code around this line gone you can move routing_info declaration and
GetModelSafeRoutingInfo call closer to the for loop that uses this data.

[skym, 2017-04-21 20:44:15]

https://codereview.chromium.org/2834453006/diff/60001/components/browser_sync...
File components/browser_sync/profile_sync_service.cc (right):

https://codereview.chromium.org/2834453006/diff/60001/components/browser_sync...
components/browser_sync/profile_sync_service.cc:1788: ModelSafeRoutingInfo
routing_info;
On 2017/04/21 20:30:06, pavely wrote:
> With the code around this line gone you can move routing_info declaration and
> GetModelSafeRoutingInfo call closer to the for loop that uses this data.

Done.

[skym, 2017-04-21 20:44:19]

The CQ bit was checked by skym@chromium.org

[skym, 2017-04-21 20:44:19]

The patchset sent to the CQ was uploaded after l-g-t-m from pavely@chromium.org
Link to the patchset: https://codereview.chromium.org/2834453006/#ps80001
(title: "Reworked some of the variables in GetTypeStatusMap().")

[commit-bot: I haz the power, 2017-04-21 20:44:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 20:53:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 20:53:43]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[skym, 2017-04-21 22:03:10]

+tommycli for chrome/browser/ui/webui/sync_internals_browsertest.js , PTAL

[skym, 2017-04-21 22:03:39]

skym@chromium.org changed reviewers:
+ tommycli@chromium.org

[skym, 2017-04-21 22:03:39]

+tommycli (for real this time) for
chrome/browser/ui/webui/sync_internals_browsertest.js , PTAL

[tommycli, 2017-04-21 22:06:56]

lgtm

[skym, 2017-04-21 22:07:42]

The CQ bit was checked by skym@chromium.org

[commit-bot: I haz the power, 2017-04-21 22:08:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 23:13:17]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492812462058700,
"parent_rev": "b31d544a5feacdf41081c52d61cacc5cb5bc10ae", "commit_rev":
"0cfadad67cd27254cce5ae62891aab6f5fc1d643"}

[commit-bot: I haz the power, 2017-04-21 23:13:29]

Description was changed from

==========
[Sync] Update Type Info section of sync-internals.

* Added DataTypeController's State to sync-internals. This should make
debugging certain issues significantly easier.
* Stopped double requesting directory status counters.
* ModelSafeGroup's ToString is no longer SHOUTY_CAPS, but Captialized
Words to be in line with ModelType, and to allow sync-internals to put
line breaks between them.
* ModelSafeGroup's ToString no longer has a default clause, to force
new values to have handling added at compile time.
* Split up ModelSafeGroup and a status/health message into two separate
column on sync-internals.
* Updated javascript updating logic to apply status counters to
correctly write zeros.

BUG=714198
==========

to

==========
[Sync] Update Type Info section of sync-internals.

* Added DataTypeController's State to sync-internals. This should make
debugging certain issues significantly easier.
* Stopped double requesting directory status counters.
* ModelSafeGroup's ToString is no longer SHOUTY_CAPS, but Captialized
Words to be in line with ModelType, and to allow sync-internals to put
line breaks between them.
* ModelSafeGroup's ToString no longer has a default clause, to force
new values to have handling added at compile time.
* Split up ModelSafeGroup and a status/health message into two separate
column on sync-internals.
* Updated javascript updating logic to apply status counters to
correctly write zeros.

BUG=714198

Review-Url: https://codereview.chromium.org/2834453006
Cr-Commit-Position: refs/heads/master@{#466486}
Committed:
https://chromium.googlesource.com/chromium/src/+/0cfadad67cd27254cce5ae62891a...
==========

[commit-bot: I haz the power, 2017-04-21 23:13:30]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/0cfadad67cd27254cce5ae62891a...