Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: components/sync/engine_impl/model_type_registry.cc

Issue 2834453006: [Sync] Update Type Info section of sync-internals. (Closed)
Patch Set: Reworked some of the variables in GetTypeStatusMap(). Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/engine/model_safe_worker_unittest.cc ('k') | components/sync/syncable/model_type.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/engine_impl/model_type_registry.cc
diff --git a/components/sync/engine_impl/model_type_registry.cc b/components/sync/engine_impl/model_type_registry.cc
index 7d15dd610422e49283b5ebc832dc479fda22e611..b6bc2e31a03ba31988af40cb60dafc0803876a2e 100644
--- a/components/sync/engine_impl/model_type_registry.cc
+++ b/components/sync/engine_impl/model_type_registry.cc
@@ -270,7 +270,9 @@ void ModelTypeRegistry::RequestEmitDebugInfo() {
for (const auto& kv : data_type_debug_info_emitter_map_) {
kv.second->EmitCommitCountersUpdate();
kv.second->EmitUpdateCountersUpdate();
- kv.second->EmitStatusCountersUpdate();
+ // Although this breaks encapsulation, don't emit status counters here.
+ // They've already been asked for manually on the UI thread because USS
+ // emitters don't have a working implementation yet.
}
}
« no previous file with comments | « components/sync/engine/model_safe_worker_unittest.cc ('k') | components/sync/syncable/model_type.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698