Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Issue 2834453004: Remove print preview scaling flag (Closed)

Created:
3 years, 8 months ago by rbpotter
Modified:
3 years, 8 months ago
Reviewers:
Lei Zhang, dpapad
CC:
arv+watch_chromium.org, asvitkine+watch_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove print preview scaling flag Remove the print scaling flag since it is now fully launched to Stable. BUG=659430 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2834453004 Cr-Commit-Position: refs/heads/master@{#467346} Committed: https://chromium.googlesource.com/chromium/src/+/f0597dfb66bbd6824a3c9e3ae14070fc882b422e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move comment #

Total comments: 2

Patch Set 3 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -71 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/print_preview/data/app_state.js View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 6 chunks +16 lines, -31 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_features.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_features.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M chrome/test/data/webui/print_preview.js View 1 2 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 25 (17 generated)
rbpotter
3 years, 8 months ago (2017-04-20 16:40:07 UTC) #8
Lei Zhang
lgtm https://codereview.chromium.org/2834453004/diff/1/chrome/common/chrome_features.cc File chrome/common/chrome_features.cc (right): https://codereview.chromium.org/2834453004/diff/1/chrome/common/chrome_features.cc#newcode261 chrome/common/chrome_features.cc:261: // Enables the Print as Image feature in ...
3 years, 8 months ago (2017-04-20 18:53:21 UTC) #9
rbpotter
https://codereview.chromium.org/2834453004/diff/1/chrome/common/chrome_features.cc File chrome/common/chrome_features.cc (right): https://codereview.chromium.org/2834453004/diff/1/chrome/common/chrome_features.cc#newcode261 chrome/common/chrome_features.cc:261: // Enables the Print as Image feature in print ...
3 years, 8 months ago (2017-04-22 00:47:27 UTC) #12
dpapad
LGTM https://codereview.chromium.org/2834453004/diff/20001/chrome/test/data/webui/print_preview.js File chrome/test/data/webui/print_preview.js (right): https://codereview.chromium.org/2834453004/diff/20001/chrome/test/data/webui/print_preview.js#newcode64 chrome/test/data/webui/print_preview.js:64: // Enable print as image for tests on ...
3 years, 8 months ago (2017-04-25 21:29:10 UTC) #13
rbpotter
https://codereview.chromium.org/2834453004/diff/20001/chrome/test/data/webui/print_preview.js File chrome/test/data/webui/print_preview.js (right): https://codereview.chromium.org/2834453004/diff/20001/chrome/test/data/webui/print_preview.js#newcode64 chrome/test/data/webui/print_preview.js:64: // Enable print as image for tests on non ...
3 years, 8 months ago (2017-04-26 00:33:01 UTC) #15
rbpotter
https://codereview.chromium.org/2834453004/diff/20001/chrome/test/data/webui/print_preview.js File chrome/test/data/webui/print_preview.js (right): https://codereview.chromium.org/2834453004/diff/20001/chrome/test/data/webui/print_preview.js#newcode64 chrome/test/data/webui/print_preview.js:64: // Enable print as image for tests on non ...
3 years, 8 months ago (2017-04-26 00:33:01 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834453004/40001
3 years, 8 months ago (2017-04-26 16:37:51 UTC) #22
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 16:42:33 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f0597dfb66bbd6824a3c9e3ae140...

Powered by Google App Engine
This is Rietveld 408576698