Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: chrome/common/chrome_features.cc

Issue 2834453004: Remove print preview scaling flag (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/chrome_features.h ('k') | chrome/test/data/webui/print_preview.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/chrome_features.h" 5 #include "chrome/common/chrome_features.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "chrome/common/chrome_switches.h" 8 #include "chrome/common/chrome_switches.h"
9 #include "extensions/features/features.h" 9 #include "extensions/features/features.h"
10 #include "ppapi/features/features.h" 10 #include "ppapi/features/features.h"
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 const base::Feature kPrefService{"PrefService", 251 const base::Feature kPrefService{"PrefService",
252 base::FEATURE_DISABLED_BY_DEFAULT}; 252 base::FEATURE_DISABLED_BY_DEFAULT};
253 253
254 #if defined(OS_CHROMEOS) 254 #if defined(OS_CHROMEOS)
255 // The lock screen will be preloaded so it is instantly available when the user 255 // The lock screen will be preloaded so it is instantly available when the user
256 // locks the Chromebook device. 256 // locks the Chromebook device.
257 const base::Feature kPreloadLockScreen{"PreloadLockScreen", 257 const base::Feature kPreloadLockScreen{"PreloadLockScreen",
258 base::FEATURE_ENABLED_BY_DEFAULT}; 258 base::FEATURE_ENABLED_BY_DEFAULT};
259 #endif 259 #endif
260 260
261 // Enables the Print Scaling feature in print preview. 261 // Enables the Print as Image feature in print preview.
Lei Zhang 2017/04/20 18:53:21 Move the comment inside the #if while we are here?
rbpotter 2017/04/22 00:47:27 Done.
262 #if BUILDFLAG(ENABLE_PRINT_PREVIEW) 262 #if BUILDFLAG(ENABLE_PRINT_PREVIEW)
263 const base::Feature kPrintPdfAsImage{"PrintPdfAsImage", 263 const base::Feature kPrintPdfAsImage{"PrintPdfAsImage",
264 base::FEATURE_DISABLED_BY_DEFAULT}; 264 base::FEATURE_DISABLED_BY_DEFAULT};
265
266 const base::Feature kPrintScaling{"PrintScaling",
267 base::FEATURE_DISABLED_BY_DEFAULT};
268 #endif 265 #endif
269 266
270 // Enables or disables push subscriptions keeping Chrome running in the 267 // Enables or disables push subscriptions keeping Chrome running in the
271 // background when closed. 268 // background when closed.
272 const base::Feature kPushMessagingBackgroundMode{ 269 const base::Feature kPushMessagingBackgroundMode{
273 "PushMessagingBackgroundMode", base::FEATURE_DISABLED_BY_DEFAULT}; 270 "PushMessagingBackgroundMode", base::FEATURE_DISABLED_BY_DEFAULT};
274 271
275 #if defined(OS_CHROMEOS) 272 #if defined(OS_CHROMEOS)
276 // Runtime flag that indicates whether this leak detector should be enabled in 273 // Runtime flag that indicates whether this leak detector should be enabled in
277 // the current instance of Chrome. 274 // the current instance of Chrome.
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
332 return base::FeatureList::IsEnabled(features::kPrefService) || 329 return base::FeatureList::IsEnabled(features::kPrefService) ||
333 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES) 330 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES)
334 base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII( 331 base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
335 switches::kMusConfig) == switches::kMash; 332 switches::kMusConfig) == switches::kMash;
336 #else 333 #else
337 false; 334 false;
338 #endif 335 #endif
339 } 336 }
340 337
341 } // namespace features 338 } // namespace features
OLDNEW
« no previous file with comments | « chrome/common/chrome_features.h ('k') | chrome/test/data/webui/print_preview.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698