Let IME frame update bypass ContentViewCore

Let IME frame update bypass ContentViewCore

Decouples IME frame update (cursor/anchor coordinates) from
ContentViewCore, hence redueces the dependency on CVC. Now 
RenderWidgetHostViewAndroid uses native ImeAdapter to route
the frame update info directly to Java layer. 

BUG=662908
Review-Url: https://codereview.chromium.org/2834343005
Cr-Commit-Position: refs/heads/master@{#467257}
Committed: https://chromium.googlesource.com/chromium/src/+/ea157e49338a21de6168d5d5873480d298294608

[Jinsuk Kim, 2017-04-25 11:13:58]

Description was changed from

==========
Let IME frame update bypass ContentViewCore

Decouples IME frame update (cursor/anchor coordinates) from
ContentViewCore. Now RenderWidgetHostViewAndroid uses
native ImeAdapter to route the frame update info directly to
Java layer.

BUG=662908
==========

to

==========
Let IME frame update bypass ContentViewCore

Decouples IME frame update (cursor/anchor coordinates) from
ContentViewCore, hence redueces the dependency on CVC. Now 
RenderWidgetHostViewAndroid uses native ImeAdapter to route
the frame update info directly to Java layer. 

BUG=662908
==========

[Jinsuk Kim, 2017-04-25 11:14:24]

jinsukkim@chromium.org changed reviewers:
+ boliu@chromium.org

[boliu, 2017-04-25 17:18:24]

https://codereview.chromium.org/2834343005/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/2834343005/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_android.cc:1374: if
(!content_view_core_ || !ime_adapter_android_)
these two should be independent..

if cvc is not there, then don't do the work for cvc, if ime adapter is not
there, then don't do work for ime adapter

[Jinsuk Kim, 2017-04-25 22:39:01]

https://codereview.chromium.org/2834343005/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/2834343005/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_android.cc:1374: if
(!content_view_core_ || !ime_adapter_android_)
On 2017/04/25 17:18:24, boliu wrote:
> these two should be independent..
> 
> if cvc is not there, then don't do the work for cvc, if ime adapter is not
> there, then don't do work for ime adapter

Done. It was not doing anything when cvc is null. So I guess they are all
regarded as 'the work for cvc'? See if this addressed as you expect.

[boliu, 2017-04-25 22:43:37]

lgtm

https://codereview.chromium.org/2834343005/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/2834343005/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_android.cc:1405:
view_.set_content_offset(gfx::Vector2dF(0.0f,
presumably all the view_ calls don't need to be guarded against !cvc either, but
that could be a follow up

[Jinsuk Kim, 2017-04-26 06:45:50]

The CQ bit was checked by jinsukkim@chromium.org

[commit-bot: I haz the power, 2017-04-26 06:46:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 07:00:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493189150858430,
"parent_rev": "61b8dd80224f465e251452cf9ca08bea8cf9d28e", "commit_rev":
"ea157e49338a21de6168d5d5873480d298294608"}

[commit-bot: I haz the power, 2017-04-26 07:00:39]

Description was changed from

==========
Let IME frame update bypass ContentViewCore

Decouples IME frame update (cursor/anchor coordinates) from
ContentViewCore, hence redueces the dependency on CVC. Now 
RenderWidgetHostViewAndroid uses native ImeAdapter to route
the frame update info directly to Java layer. 

BUG=662908
==========

to

==========
Let IME frame update bypass ContentViewCore

Decouples IME frame update (cursor/anchor coordinates) from
ContentViewCore, hence redueces the dependency on CVC. Now 
RenderWidgetHostViewAndroid uses native ImeAdapter to route
the frame update info directly to Java layer. 

BUG=662908

Review-Url: https://codereview.chromium.org/2834343005
Cr-Commit-Position: refs/heads/master@{#467257}
Committed:
https://chromium.googlesource.com/chromium/src/+/ea157e49338a21de6168d5d58734...
==========

[commit-bot: I haz the power, 2017-04-26 07:00:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ea157e49338a21de6168d5d58734...