Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

Issue 2834343005: Let IME frame update bypass ContentViewCore (Closed)
Patch Set: comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
index d9905d51730c86a6d0972fc618a6ea83a92f6e75..d7f70154e5fef20d7d0675f27394d7e41102cd08 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
@@ -33,7 +33,6 @@ import org.chromium.base.annotations.JNINamespace;
import org.chromium.blink_public.web.WebInputEventModifier;
import org.chromium.blink_public.web.WebInputEventType;
import org.chromium.blink_public.web.WebTextInputMode;
-import org.chromium.content.browser.RenderCoordinates;
import org.chromium.content.browser.ViewUtils;
import org.chromium.content.browser.picker.InputDialogContainer;
import org.chromium.content_public.browser.ImeEventObserver;
@@ -823,8 +822,8 @@ public class ImeAdapter {
/**
* Notified when a frame has been produced by the renderer and all the associated metadata.
- * @param renderCoordinates coordinate information to convert CSS (document) coordinates to
- * View-local Physical (screen) coordinates
+ * @param scaleFactor device scale factor.
+ * @param contentOffsetYPix Y offset below the browser controls.
* @param hasInsertionMarker Whether the insertion marker is visible or not.
* @param insertionMarkerHorizontal X coordinates (in view-local DIP pixels) of the insertion
* marker if it exists. Will be ignored otherwise.
@@ -833,13 +832,15 @@ public class ImeAdapter {
* @param insertionMarkerBottom Y coordinates (in view-local DIP pixels) of the bottom of
* the insertion marker if it exists. Will be ignored otherwise.
*/
- public void onUpdateFrameInfo(RenderCoordinates renderCoordinates, boolean hasInsertionMarker,
- boolean isInsertionMarkerVisible, float insertionMarkerHorizontal,
- float insertionMarkerTop, float insertionMarkerBottom) {
+ @CalledByNative
+ private void updateFrameInfo(float scaleFactor, float contentOffsetYPix,
+ boolean hasInsertionMarker, boolean isInsertionMarkerVisible,
+ float insertionMarkerHorizontal, float insertionMarkerTop,
+ float insertionMarkerBottom) {
if (mCursorAnchorInfoController == null) return;
- mCursorAnchorInfoController.onUpdateFrameInfo(renderCoordinates, hasInsertionMarker,
- isInsertionMarkerVisible, insertionMarkerHorizontal, insertionMarkerTop,
- insertionMarkerBottom, mContainerView);
+ mCursorAnchorInfoController.onUpdateFrameInfo(scaleFactor, contentOffsetYPix,
+ hasInsertionMarker, isInsertionMarkerVisible, insertionMarkerHorizontal,
+ insertionMarkerTop, insertionMarkerBottom, mContainerView);
}
@CalledByNative

Powered by Google App Engine
This is Rietveld 408576698