Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2834153002: Introduce Value::GetList and Value(ListStorage) (Closed)

Created:
3 years, 8 months ago by vabr (Chromium)
Modified:
3 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Introduce Value::GetList and Value(ListStorage) As part of the ongoing effort to move base::Value to value semantics this change introduces base::Value::GetList accessors that expose the underlying ListStorage of the ListValue. This builds on top of r463684 which made the necessary modifications to ListStorage. Furthermore this change deprecates the existing ListValue API in favor of using std::vector's API directly. Lastly, constructors taking ListStorage parameters are introduced to be consistent with already existing constructors as well as making it convenient to create ListValues from previously existing std::vector<base::Value>s. R=brettw@chromium.org BUG=646113 Review-Url: https://codereview.chromium.org/2823233002 Cr-Commit-Position: refs/heads/master@{#465517} (cherry picked from commit 2b7d0fcd0261f43efa4592f49238270f500cc39a) Review-Url: https://codereview.chromium.org/2834153002 . Cr-Commit-Position: refs/branch-heads/3071@{#125} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/46374032b1f5791045c20d3608e8df8258709b8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -37 lines) Patch
M base/values.h View 2 chunks +6 lines, -0 lines 0 comments Download
M base/values.cc View 3 chunks +24 lines, -9 lines 0 comments Download
M base/values_unittest.cc View 3 chunks +15 lines, -28 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
vabr (Chromium)
3 years, 8 months ago (2017-04-21 18:35:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
46374032b1f5791045c20d3608e8df8258709b8b.

Powered by Google App Engine
This is Rietveld 408576698