cc: Replace render surface layer list with a render surface list

cc: Replace render surface layer list with a render surface list

The render surface layer list structure consisted of a top level
list of layers representing render surfaces, along with a list of
layers at each surface representing contributing layers or surfaces.

This CL replaces the render surface layer list with a top level
list of surfaces. Individual surfaces no longer store a list of
contributors.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2834123002
Cr-Commit-Position: refs/heads/master@{#468168}
Committed: https://chromium.googlesource.com/chromium/src/+/b784ef49f2e1609ccec5007fe9229186d34a432d

[ajuma, 2017-04-21 15:22:04]

Description was changed from

==========
cc: Remove render surface layer list

WIP

BUG=611883
==========

to

==========
cc: Remove render surface layer list

WIP

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ajuma, 2017-04-27 19:52:26]

Description was changed from

==========
cc: Remove render surface layer list

WIP

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Replace render surface layer list with render surface list

The render surface layer list structure consisted of a top level
list of layers representing render surfaces, along with a list of
layers at each surface representing contributing layers or surfaces.

This CL replaces the render surface layer list with a top level
list of surfaces.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ajuma, 2017-04-27 19:53:48]

Description was changed from

==========
cc: Replace render surface layer list with render surface list

The render surface layer list structure consisted of a top level
list of layers representing render surfaces, along with a list of
layers at each surface representing contributing layers or surfaces.

This CL replaces the render surface layer list with a top level
list of surfaces.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Replace render surface layer list with a render surface list

The render surface layer list structure consisted of a top level
list of layers representing render surfaces, along with a list of
layers at each surface representing contributing layers or surfaces.

This CL replaces the render surface layer list with a top level
list of surfaces. Individual surfaces no longer store a list of
contributors.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ajuma, 2017-04-27 19:53:53]

The CQ bit was checked by ajuma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 19:54:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 20:14:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 20:14:39]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[ajuma, 2017-04-27 21:00:52]

The CQ bit was checked by ajuma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 21:01:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ajuma, 2017-04-27 21:06:40]

Description was changed from

==========
cc: Replace render surface layer list with a render surface list

The render surface layer list structure consisted of a top level
list of layers representing render surfaces, along with a list of
layers at each surface representing contributing layers or surfaces.

This CL replaces the render surface layer list with a top level
list of surfaces. Individual surfaces no longer store a list of
contributors.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Replace render surface layer list with a render surface list

The render surface layer list structure consisted of a top level
list of layers representing render surfaces, along with a list of
layers at each surface representing contributing layers or surfaces.

This CL replaces the render surface layer list with a top level
list of surfaces. Individual surfaces no longer store a list of
contributors.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[commit-bot: I haz the power, 2017-04-27 21:27:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 21:27:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ajuma, 2017-04-27 21:39:17]

The CQ bit was checked by ajuma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 21:39:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ajuma, 2017-04-27 23:34:41]

ajuma@chromium.org changed reviewers:
+ jaydasika@chromium.org, weiliangc@chromium.org

[ajuma, 2017-04-27 23:35:23]

https://codereview.chromium.org/2834123002/diff/120001/cc/trees/layer_tree_ho...
File cc/trees/layer_tree_host_common.cc (right):

https://codereview.chromium.org/2834123002/diff/120001/cc/trees/layer_tree_ho...
cc/trees/layer_tree_host_common.cc:348:
layer->set_is_drawn_render_surface_layer_list_member(false);
LayerImpl::is_drawn_render_surface_layer_list_member needs a new name now (e.g.
contributes_to_drawn_render_surface) but I'd rather do that in a follow-up.

[commit-bot: I haz the power, 2017-04-28 01:37:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 01:37:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ajuma, 2017-04-28 13:25:28]

The CQ bit was checked by ajuma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 13:25:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 14:10:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 14:10:32]

Dry run: This issue passed the CQ dry run.

[jaydasika, 2017-04-28 18:27:18]

https://codereview.chromium.org/2834123002/diff/120001/cc/layers/render_surfa...
File cc/layers/render_surface_impl.h (right):

https://codereview.chromium.org/2834123002/diff/120001/cc/layers/render_surfa...
cc/layers/render_surface_impl.h:130: void decrement_num_contributors() {
num_contributors_--; }
Add a DCHECK here for num_contributors_ >= 0 after decrementing ?

https://codereview.chromium.org/2834123002/diff/120001/cc/trees/layer_tree_ho...
File cc/trees/layer_tree_host_common.cc (right):

https://codereview.chromium.org/2834123002/diff/120001/cc/trees/layer_tree_ho...
cc/trees/layer_tree_host_common.cc:399: RenderSurfaceImpl* render_target =
render_surface->render_target();
Can you DCHECK here for render_target->is_render_surface_list_member() ?

https://codereview.chromium.org/2834123002/diff/120001/cc/trees/layer_tree_ho...
cc/trees/layer_tree_host_common.cc:434:
layer->set_is_drawn_render_surface_layer_list_member(false);
Should we also have layer->render_target()->decrement_num_contributors() here ?

[ajuma, 2017-04-28 21:00:04]

The CQ bit was checked by ajuma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 21:00:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ajuma, 2017-04-28 21:11:21]

https://codereview.chromium.org/2834123002/diff/120001/cc/layers/render_surfa...
File cc/layers/render_surface_impl.h (right):

https://codereview.chromium.org/2834123002/diff/120001/cc/layers/render_surfa...
cc/layers/render_surface_impl.h:130: void decrement_num_contributors() {
num_contributors_--; }
On 2017/04/28 18:27:18, jaydasika wrote:
> Add a DCHECK here for num_contributors_ >= 0 after decrementing ?

Done.

https://codereview.chromium.org/2834123002/diff/120001/cc/trees/layer_tree_ho...
File cc/trees/layer_tree_host_common.cc (right):

https://codereview.chromium.org/2834123002/diff/120001/cc/trees/layer_tree_ho...
cc/trees/layer_tree_host_common.cc:399: RenderSurfaceImpl* render_target =
render_surface->render_target();
On 2017/04/28 18:27:18, jaydasika wrote:
> Can you DCHECK here for render_target->is_render_surface_list_member() ?

Done.

https://codereview.chromium.org/2834123002/diff/120001/cc/trees/layer_tree_ho...
cc/trees/layer_tree_host_common.cc:434:
layer->set_is_drawn_render_surface_layer_list_member(false);
On 2017/04/28 18:27:18, jaydasika wrote:
> Should we also have layer->render_target()->decrement_num_contributors() here
?

Done.

[jaydasika, 2017-04-28 21:23:47]

lgtm

[commit-bot: I haz the power, 2017-04-28 22:18:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 22:18:59]

Dry run: This issue passed the CQ dry run.

[ajuma, 2017-04-28 22:53:36]

The CQ bit was checked by ajuma@chromium.org

[commit-bot: I haz the power, 2017-04-28 22:54:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 23:01:55]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1493420016008560,
"parent_rev": "262e77a72493e36e8006aeeba1c7497a42ee5ad9", "commit_rev":
"b784ef49f2e1609ccec5007fe9229186d34a432d"}

[commit-bot: I haz the power, 2017-04-28 23:04:33]

Description was changed from

==========
cc: Replace render surface layer list with a render surface list

The render surface layer list structure consisted of a top level
list of layers representing render surfaces, along with a list of
layers at each surface representing contributing layers or surfaces.

This CL replaces the render surface layer list with a top level
list of surfaces. Individual surfaces no longer store a list of
contributors.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Replace render surface layer list with a render surface list

The render surface layer list structure consisted of a top level
list of layers representing render surfaces, along with a list of
layers at each surface representing contributing layers or surfaces.

This CL replaces the render surface layer list with a top level
list of surfaces. Individual surfaces no longer store a list of
contributors.

BUG=611883
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2834123002
Cr-Commit-Position: refs/heads/master@{#468168}
Committed:
https://chromium.googlesource.com/chromium/src/+/b784ef49f2e1609ccec5007fe922...
==========

[commit-bot: I haz the power, 2017-04-28 23:04:34]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/b784ef49f2e1609ccec5007fe922...