Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2833833002: Fix official builds on ios 8.3+ (Closed)

Created:
3 years, 8 months ago by lody
Modified:
3 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, sdefresne
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix official builds on ios 8.3+ Conditionally disable the warning based on the value of the "xcode_version" variable. To be reverted when all bots are on 8.3. BUG=712731 Review-Url: https://codereview.chromium.org/2833833002 Cr-Commit-Position: refs/heads/master@{#466157} Committed: https://chromium.googlesource.com/chromium/src/+/b1eb09e2deb0335502f6b744a902dd0251a209f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M build/config/compiler/BUILD.gn View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
lody
Hi Thakis, please review this change you suggested on the bug. Thank you!
3 years, 8 months ago (2017-04-20 17:06:08 UTC) #2
Nico
lgtm
3 years, 8 months ago (2017-04-20 17:11:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833833002/1
3 years, 8 months ago (2017-04-20 20:58:38 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 22:09:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b1eb09e2deb0335502f6b744a902...

Powered by Google App Engine
This is Rietveld 408576698