Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2833833002: Fix official builds on ios 8.3+ (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 630db84f14be471ba134fa4bb559c5808e25cbff..1cf6669ed4f6933d88fb03205914dbcf5c310fb9 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -20,6 +20,9 @@ if (current_cpu == "mipsel" || current_cpu == "mips64el") {
if (is_mac) {
import("//build/config/mac/symbols.gni")
}
+if (is_ios) {
+ import("//build/config/ios/ios_sdk.gni")
+}
declare_args() {
# Default to warnings as errors for default workflow, where we catch
@@ -1102,6 +1105,17 @@ config("default_warnings") {
# TODO(thakis ): https://crbug.com/683349
"-Wno-user-defined-warnings",
]
+ } else if (use_xcode_clang &&
+ (xcode_version == "0830" || xcode_version == "0831" ||
+ xcode_version == "0832")) {
+ # This is necessary to allow a progressive transition from using xcode 8 to 8.3. Remove when all bots are migrated to 8.3.
+ cflags += [
+ # TODO(thakis): https://crbug.com/604888
+ "-Wno-undefined-var-template",
+
+ # TODO(hans): https://crbug.com/637306
+ "-Wno-address-of-packed-member",
+ ]
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698