Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2833783002: [compiler] Add instrumentation for tracking down Node::New crashes. (Closed)

Created:
3 years, 8 months ago by neis
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Add instrumentation for tracking down Node::New crashes. R=jarin@chromium.org BUG=chromium:713584 Review-Url: https://codereview.chromium.org/2833783002 Cr-Commit-Position: refs/heads/master@{#44748} Committed: https://chromium.googlesource.com/v8/v8/+/7a12fc0051ce334a3e74138f6faaba12463a37ce

Patch Set 1 #

Patch Set 2 : Take no risks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 1 4 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
neis
3 years, 8 months ago (2017-04-20 11:29:36 UTC) #1
Jarin
lgtm
3 years, 8 months ago (2017-04-20 14:25:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833783002/20001
3 years, 8 months ago (2017-04-20 14:26:25 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 14:28:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/7a12fc0051ce334a3e74138f6faaba12463...

Powered by Google App Engine
This is Rietveld 408576698