Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: src/compiler/effect-control-linearizer.cc

Issue 2833783002: [compiler] Add instrumentation for tracking down Node::New crashes. (Closed)
Patch Set: Take no risks. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/effect-control-linearizer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/effect-control-linearizer.cc
diff --git a/src/compiler/effect-control-linearizer.cc b/src/compiler/effect-control-linearizer.cc
index 0e48932c8dd2157538a1691ed55f259b039731a8..6a75e8cff234aa519a7f413e4befa7f1af09e597 100644
--- a/src/compiler/effect-control-linearizer.cc
+++ b/src/compiler/effect-control-linearizer.cc
@@ -26,7 +26,8 @@ EffectControlLinearizer::EffectControlLinearizer(
schedule_(schedule),
temp_zone_(temp_zone),
source_positions_(source_positions),
- graph_assembler_(js_graph, nullptr, nullptr, temp_zone) {}
+ graph_assembler_(js_graph, nullptr, nullptr, temp_zone),
+ frame_state_zapper_(nullptr) {}
Graph* EffectControlLinearizer::graph() const { return js_graph_->graph(); }
CommonOperatorBuilder* EffectControlLinearizer::common() const {
@@ -429,6 +430,7 @@ void EffectControlLinearizer::Run() {
if (block_effects.For(block->PredecessorAt(i), block)
.current_frame_state != frame_state) {
frame_state = nullptr;
+ frame_state_zapper_ = graph()->end();
break;
}
}
@@ -502,6 +504,7 @@ void EffectControlLinearizer::ProcessNode(Node* node, Node** frame_state,
if (region_observability_ == RegionObservability::kObservable &&
!node->op()->HasProperty(Operator::kNoWrite)) {
*frame_state = nullptr;
+ frame_state_zapper_ = node;
}
// Remove the end markers of 'atomic' allocation region because the
@@ -681,6 +684,11 @@ bool EffectControlLinearizer::TryWireInStateEffect(Node* node,
result = LowerCheckedFloat64ToInt32(node, frame_state);
break;
case IrOpcode::kCheckedTaggedSignedToInt32:
+ if (frame_state == nullptr) {
+ V8_Fatal(__FILE__, __LINE__, "No frame state (zapped by #%d: %s)",
+ frame_state_zapper_->id(),
+ frame_state_zapper_->op()->mnemonic());
+ }
result = LowerCheckedTaggedSignedToInt32(node, frame_state);
break;
case IrOpcode::kCheckedTaggedToInt32:
« no previous file with comments | « src/compiler/effect-control-linearizer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698