[sync] Add android test that ensures tabs get a valid sync id

[sync] Add android test that ensures tabs get a valid  sync id

Add an OpenTabsTest that checks the sync id for a new tab, making sure
it's not invalid. This test fails with my previous change reverted.

R=zea@chromium.org

BUG=711847
Review-Url: https://codereview.chromium.org/2833763003
Cr-Commit-Position: refs/heads/master@{#466161}
Committed: https://chromium.googlesource.com/chromium/src/+/c2a141ce2ea4ea1a2826861798370bb91866f620

[Patrick Noland, 2017-04-20 19:00:00]

The CQ bit was checked by pnoland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 19:00:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Patrick Noland, 2017-04-20 19:03:48]

Nicolas,PTAL

[skym, 2017-04-20 19:10:51]

skym@chromium.org changed reviewers:
+ skym@chromium.org

[skym, 2017-04-20 19:10:52]

Couple of nits, lgtm, but I'm not an owner so zea is still needed.

https://codereview.chromium.org/2833763003/diff/1/chrome/android/sync_shell/j...
File
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java
(right):

https://codereview.chromium.org/2833763003/diff/1/chrome/android/sync_shell/j...
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java:183:
// Test
Looks like the beginning of a description!

https://codereview.chromium.org/2833763003/diff/1/chrome/android/sync_shell/j...
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java:188:

This test is so small, I'd remove the newline, but this is totally just style,
feel free to disregard.

https://codereview.chromium.org/2833763003/diff/1/chrome/android/sync_shell/j...
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java:190:
assertFalse(state.syncId == SyncConstants.INVALID_TAB_NODE_ID);
assertNotSame

https://codereview.chromium.org/2833763003/diff/1/chrome/android/sync_shell/j...
chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java:191:
}
Should we have a test that ensure's we do get an INVALID_TAB_NODE_ID in some
case? Like if something was incorrectly using 0 instead of -1 like it used to
be, this test would be passing and we wouldn't really be guaranteeing anything.

[commit-bot: I haz the power, 2017-04-20 19:28:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 19:28:41]

Dry run: This issue passed the CQ dry run.

[Nicolas Zea, 2017-04-20 21:17:04]

lgtm

[Patrick Noland, 2017-04-20 21:38:36]

The CQ bit was checked by pnoland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 21:39:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 22:10:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 22:10:49]

Dry run: This issue passed the CQ dry run.

[Patrick Noland, 2017-04-20 22:16:12]

The CQ bit was checked by pnoland@chromium.org

[Patrick Noland, 2017-04-20 22:16:13]

The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org,
skym@chromium.org
Link to the patchset: https://codereview.chromium.org/2833763003/#ps20001
(title: "Added invalid id test")

[commit-bot: I haz the power, 2017-04-20 22:16:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 22:21:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492726572873000,
"parent_rev": "76209400f9091745a4ecc635223c5e9a86c96939", "commit_rev":
"c2a141ce2ea4ea1a2826861798370bb91866f620"}

[commit-bot: I haz the power, 2017-04-20 22:21:58]

Description was changed from

==========
[sync] Add android test that ensures tabs get a valid  sync id

Add an OpenTabsTest that checks the sync id for a new tab, making sure
it's not invalid. This test fails with my previous change reverted.

R=zea@chromium.org

BUG=711847
==========

to

==========
[sync] Add android test that ensures tabs get a valid  sync id

Add an OpenTabsTest that checks the sync id for a new tab, making sure
it's not invalid. This test fails with my previous change reverted.

R=zea@chromium.org

BUG=711847

Review-Url: https://codereview.chromium.org/2833763003
Cr-Commit-Position: refs/heads/master@{#466161}
Committed:
https://chromium.googlesource.com/chromium/src/+/c2a141ce2ea4ea1a282686179837...
==========

[commit-bot: I haz the power, 2017-04-20 22:21:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c2a141ce2ea4ea1a282686179837...