Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java

Issue 2833763003: [sync] Add android test that ensures tabs get a valid sync id (Closed)
Patch Set: Added invalid id test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java
diff --git a/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java b/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java
index d09e427187a4dda39cccb47ba2c608f7e1f54d44..aebb750f84870b875ed1ed78e0a2847bba51f475 100644
--- a/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java
+++ b/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java
@@ -15,9 +15,12 @@ import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.FlakyTest;
import org.chromium.base.test.util.RetryOnFailure;
+import org.chromium.chrome.browser.TabState;
+import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tabmodel.TabModelSelector;
import org.chromium.chrome.browser.tabmodel.TabModelUtils;
import org.chromium.chrome.test.util.browser.sync.SyncTestUtil;
+import org.chromium.components.sync.SyncConstants;
import org.chromium.components.sync.protocol.EntitySpecifics;
import org.chromium.components.sync.protocol.SessionHeader;
import org.chromium.components.sync.protocol.SessionSpecifics;
@@ -177,6 +180,26 @@ public class OpenTabsTest extends SyncTestBase {
waitForLocalTabsForClient(FAKE_CLIENT);
}
+ // Test
+ @LargeTest
+ @Feature({"Sync"})
+ public void testTabGetsValidSyncId() throws Exception {
+ Tab tab = loadUrlInNewTab(URL);
+
+ TabState state = tab.getState();
+ assertFalse(state.syncId == SyncConstants.INVALID_TAB_NODE_ID);
+ }
+
+ // Test
+ @LargeTest
+ @Feature({"Sync"})
+ public void testIncognitoTabGetsInvalidSyncId() throws Exception {
+ Tab tab = loadUrlInNewTab(URL, /*incognito=*/true);
+
+ TabState state = tab.getState();
+ assertEquals(state.syncId, SyncConstants.INVALID_TAB_NODE_ID);
+ }
+
private String makeSessionTag() {
return SESSION_TAG_PREFIX + (mSessionTagCounter++);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698