Various DDC fixes for windows

Various DDC fixes for windows

This gets most tests compiling and running on Windows.

Fixes #27450
Fixes #27797
Fixes #28752

R=jmesserly@google.com

Committed: https://github.com/dart-lang/sdk/commit/21c38e6c8c4447e479301f54c40925c8cb0a07d1

[vsm, 2017-04-19 23:45:52]

Description was changed from

==========
Various DDC fixes for windows

This gets most tests compiling and running on Windows.

Fixes #27450
Fixes #27797
Fixes #28752
==========

to

==========
Various DDC fixes for windows

This gets most tests compiling and running on Windows.

Fixes #27450
Fixes #27797
Fixes #28752
==========

[vsm, 2017-04-19 23:45:52]

vsm@google.com changed reviewers:
+ jacobr@google.com

[vsm, 2017-04-20 18:16:57]

vsm@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2017-04-20 18:22:39]

C:\this\cl/LGTM

https://codereview.chromium.org/2833633002/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/compiler.dart (right):

https://codereview.chromium.org/2833633002/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/compiler.dart:616: // Convert a source string
to a Uri.  The [source] may be a Dart URI, a file URI,
long line

https://codereview.chromium.org/2833633002/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/source_map_printer.dart (right):

https://codereview.chromium.org/2833633002/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/source_map_printer.dart:70: return;
I think this needs to be { ... } per style guide

BTW, now that you've added isSynthetic you might be able to remove `node.offset
== -1` ?

[vsm, 2017-04-20 18:29:06]

https://codereview.chromium.org/2833633002/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/compiler.dart (right):

https://codereview.chromium.org/2833633002/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/compiler.dart:616: // Convert a source string
to a Uri.  The [source] may be a Dart URI, a file URI,
On 2017/04/20 18:22:39, Jennifer Messerly wrote:
> long line

Done.

https://codereview.chromium.org/2833633002/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/source_map_printer.dart (right):

https://codereview.chromium.org/2833633002/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/source_map_printer.dart:70: return;
On 2017/04/20 18:22:39, Jennifer Messerly wrote:
> I think this needs to be { ... } per style guide

Done

> 
> BTW, now that you've added isSynthetic you might be able to remove
`node.offset
> == -1` ?

I put that in to match the enterNode above.  Can we remove both?

[vsm, 2017-04-20 18:31:05]

Description was changed from

==========
Various DDC fixes for windows

This gets most tests compiling and running on Windows.

Fixes #27450
Fixes #27797
Fixes #28752
==========

to

==========
Various DDC fixes for windows

This gets most tests compiling and running on Windows.

Fixes #27450
Fixes #27797
Fixes #28752

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/sdk/commit/21c38e6c8c4447e479301f54c40925c8cb0a07d1
==========

[vsm, 2017-04-20 18:31:06]

Committed patchset #2 (id:20001) manually as
21c38e6c8c4447e479301f54c40925c8cb0a07d1 (presubmit successful).